All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Cc: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
	alsa-devel@alsa-project.org, Mike Frysinger <vapier@gentoo.org>,
	qi.wang@intel.com, Takashi Iwai <tiwai@suse.de>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	linux-kernel@vger.kernel.org, yong.y.wang@intel.com,
	kok.howg.ewe@intel.com, Daniel Mack <zonque@gmail.com>,
	Liam Girdwood <lrg@ti.com>,
	joel.clark@intel.com
Subject: Re: [PATCH v3] sound/soc/codecs: add LAPIS Semiconductor ML26124
Date: Thu, 01 Dec 2011 20:36:20 +0100	[thread overview]
Message-ID: <4ED7D734.4020301@metafoo.de> (raw)
In-Reply-To: <CANKRQniP=UUAPbbyoZNvxs16H7QZzS=O9zwt6kJu69u8s8qGTQ@mail.gmail.com>

On 12/01/2011 08:46 AM, Tomoya MORINAGA wrote:
> 2011/11/29 Lars-Peter Clausen <lars@metafoo.de>:
>>
>> Also this doesn't make much sense:
>> +       {"Input Mux", "Analog MIC in", "MICBIAS"},
>> +       {"Input Mux", "Digital MIC in", "MICBIAS"},
>>
>> You have mux, but both possible settings of the mux connect to the same
>> source, which pretty much makes the mux useless.
>>
> 
> Yes, you are right.
> This setting was miss-settings.
> This MICBIAS supplies to external MIC as reference voltage.
> So, I think MICBIAS shouldn't appear at this setting.
> I show modified settings.
>        /* input */
>        {"Input Mux", "Analog MIC SingleEnded in", "MIN"},
>        {"Input Mux", "Analog MIC Differential in", "MIN"},
>        {"Input Mux", "Digital MIC in", "MDIN"},
>        {"ADC", "PGA", "Input Mux"},
> 

The middle part(the control) of the path must either be a control attached to
the mixer on the left side(the sink) or a element of the mux's enum if a mux is
on the left side. If the left side is neither a mixer or a mux the middle part
is ignored.

The other problem probably is that you have one mux which lets you switch
between single-ended analog input, differential analog input and digital input.
The first two options are routed through PGA and ADC the later not.

- Lars

WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars@metafoo.de>
To: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Cc: Liam Girdwood <lrg@ti.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
	Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
	Mike Frysinger <vapier@gentoo.org>,
	Daniel Mack <zonque@gmail.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	qi.wang@intel.com, yong.y.wang@intel.com, joel.clark@intel.com,
	kok.howg.ewe@intel.com
Subject: Re: [PATCH v3] sound/soc/codecs: add LAPIS Semiconductor ML26124
Date: Thu, 01 Dec 2011 20:36:20 +0100	[thread overview]
Message-ID: <4ED7D734.4020301@metafoo.de> (raw)
In-Reply-To: <CANKRQniP=UUAPbbyoZNvxs16H7QZzS=O9zwt6kJu69u8s8qGTQ@mail.gmail.com>

On 12/01/2011 08:46 AM, Tomoya MORINAGA wrote:
> 2011/11/29 Lars-Peter Clausen <lars@metafoo.de>:
>>
>> Also this doesn't make much sense:
>> +       {"Input Mux", "Analog MIC in", "MICBIAS"},
>> +       {"Input Mux", "Digital MIC in", "MICBIAS"},
>>
>> You have mux, but both possible settings of the mux connect to the same
>> source, which pretty much makes the mux useless.
>>
> 
> Yes, you are right.
> This setting was miss-settings.
> This MICBIAS supplies to external MIC as reference voltage.
> So, I think MICBIAS shouldn't appear at this setting.
> I show modified settings.
>        /* input */
>        {"Input Mux", "Analog MIC SingleEnded in", "MIN"},
>        {"Input Mux", "Analog MIC Differential in", "MIN"},
>        {"Input Mux", "Digital MIC in", "MDIN"},
>        {"ADC", "PGA", "Input Mux"},
> 

The middle part(the control) of the path must either be a control attached to
the mixer on the left side(the sink) or a element of the mux's enum if a mux is
on the left side. If the left side is neither a mixer or a mux the middle part
is ignored.

The other problem probably is that you have one mux which lets you switch
between single-ended analog input, differential analog input and digital input.
The first two options are routed through PGA and ADC the later not.

- Lars

  reply	other threads:[~2011-12-01 19:37 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-28 10:05 [PATCH v3] sound/soc/codecs: add LAPIS Semiconductor ML26124 Tomoya MORINAGA
2011-11-28 12:21 ` Lars-Peter Clausen
2011-11-28 12:21   ` Lars-Peter Clausen
2011-11-29 12:17   ` Tomoya MORINAGA
2011-11-29 14:38     ` Lars-Peter Clausen
2011-11-29 14:38       ` Lars-Peter Clausen
2011-11-29 14:38       ` Mark Brown
2011-11-29 14:38         ` Mark Brown
2011-12-01  7:46       ` Tomoya MORINAGA
2011-12-01 19:36         ` Lars-Peter Clausen [this message]
2011-12-01 19:36           ` Lars-Peter Clausen
2011-12-02  5:12           ` Tomoya MORINAGA
2011-11-28 13:23 ` Mark Brown
2011-11-29 12:14   ` Tomoya MORINAGA
2011-11-29 12:29     ` Mark Brown
2011-11-29 12:29       ` Mark Brown
2011-12-01  7:34       ` Tomoya MORINAGA
2011-12-01  7:40         ` Takashi Iwai
2011-12-01  7:40           ` Takashi Iwai
2011-12-01  7:57           ` Tomoya MORINAGA
2011-12-01  7:57             ` Tomoya MORINAGA
2011-12-01 11:11             ` Mark Brown
2011-12-01 11:11               ` Mark Brown
2011-12-02  0:33               ` Tomoya MORINAGA
2011-12-02  1:06                 ` Mark Brown
2011-12-02  1:06                   ` Mark Brown
2011-12-02  2:20                   ` Tomoya MORINAGA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ED7D734.4020301@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dp@opensource.wolfsonmicro.com \
    --cc=joel.clark@intel.com \
    --cc=kok.howg.ewe@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=qi.wang@intel.com \
    --cc=tiwai@suse.de \
    --cc=tomoya.rohm@gmail.com \
    --cc=vapier@gentoo.org \
    --cc=yong.y.wang@intel.com \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.