All of lore.kernel.org
 help / color / mirror / Atom feed
From: Digimer <linux@alteeve.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] patch for cluster 3.1.8's 'configure'
Date: Fri, 02 Dec 2011 00:42:03 -0500	[thread overview]
Message-ID: <4ED8652B.6030407@alteeve.com> (raw)

This patch fixes two small bugs in cluster's "configure" script;

1. When checking the x.y.z kernel version values, it changes the '!$foo'
to 'not defined $foo'. This is because a version number of '0' matches
"not" (!$foo). A safer but slower approach would be to do '$foo =~
/^\d+$/'. Not sure which is preferred.

2. Added a check where if 'x' in 'x.y.z' is greater in the detected
kernel than in the minimum required kernel, the test passes. This
handles 3.x kernels where the minimum is 2.y.

I tested this patch against Fedora 16 x86-64 and Ubuntu 11.10 amd64.

-- 
Digimer
E-Mail:              digimer at alteeve.com
Freenode handle:     digimer
Papers and Projects: http://alteeve.com
Node Assassin:       http://nodeassassin.org
"omg my singularity battery is dead again.
stupid hawking radiation." - epitron
-------------- next part --------------
A non-text attachment was scrubbed...
Name: configure_detect-kernel-3-properly.patch
Type: text/x-patch
Size: 852 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20111202/d3c16be6/attachment.bin>

                 reply	other threads:[~2011-12-02  5:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ED8652B.6030407@alteeve.com \
    --to=linux@alteeve.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.