All of lore.kernel.org
 help / color / mirror / Atom feed
* [Cluster-devel] patch for cluster 3.1.8's 'configure'
@ 2011-12-02  5:42 Digimer
  0 siblings, 0 replies; only message in thread
From: Digimer @ 2011-12-02  5:42 UTC (permalink / raw)
  To: cluster-devel.redhat.com

This patch fixes two small bugs in cluster's "configure" script;

1. When checking the x.y.z kernel version values, it changes the '!$foo'
to 'not defined $foo'. This is because a version number of '0' matches
"not" (!$foo). A safer but slower approach would be to do '$foo =~
/^\d+$/'. Not sure which is preferred.

2. Added a check where if 'x' in 'x.y.z' is greater in the detected
kernel than in the minimum required kernel, the test passes. This
handles 3.x kernels where the minimum is 2.y.

I tested this patch against Fedora 16 x86-64 and Ubuntu 11.10 amd64.

-- 
Digimer
E-Mail:              digimer at alteeve.com
Freenode handle:     digimer
Papers and Projects: http://alteeve.com
Node Assassin:       http://nodeassassin.org
"omg my singularity battery is dead again.
stupid hawking radiation." - epitron
-------------- next part --------------
A non-text attachment was scrubbed...
Name: configure_detect-kernel-3-properly.patch
Type: text/x-patch
Size: 852 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20111202/d3c16be6/attachment.bin>

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-12-02  5:42 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-02  5:42 [Cluster-devel] patch for cluster 3.1.8's 'configure' Digimer

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.