From: Marc Zyngier <marc.zyngier@arm.com>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: 'Axel Lin' <axel.lin@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
'Russell King' <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>
Subject: Re: [PATCH 1/2] ARM: exynos4: Fix build error due to 'gic_bank_offset' undeclared
Date: Fri, 02 Dec 2011 09:24:38 +0000 [thread overview]
Message-ID: <4ED89956.9060908@arm.com> (raw)
In-Reply-To: <04f701ccb0ce$7c044d30$740ce790$%kim@samsung.com>
On 02/12/11 08:43, Kukjin Kim wrote:
> Marc Zyngier wrote:
>>
>> On 01/12/11 15:24, Axel Lin wrote:
>>> Fix below build error:
>>> CC arch/arm/mach-exynos/cpu.o
>>> arch/arm/mach-exynos/cpu.c: In function 'exynos4_init_irq':
>>> arch/arm/mach-exynos/cpu.c:245: error: 'gic_bank_offset' undeclared
>> (first use in this function)
>>> arch/arm/mach-exynos/cpu.c:245: error: (Each undeclared identifier is
>> reported only once
>>> arch/arm/mach-exynos/cpu.c:245: error: for each function it appears in.)
>>> arch/arm/mach-exynos/cpu.c:243: warning: unused variable 'bank_offset'
>>> make[1]: *** [arch/arm/mach-exynos/cpu.o] Error 1
>>> make: *** [arch/arm/mach-exynos] Error 2
>>>
>>> Signed-off-by: Axel Lin <axel.lin@gmail.com>
>>
>> Arghhh... My bad. Thanks for fixing that.
>>
>> Acked-by: Marc Zyngier <marc.zyngier@arm.com>
>>
> Hi Marc,
>
> Since the commit 4e44d2cb("ARM: exynos4: convert to CONFIG_MULTI_IRQ_HANDLER") is not in my tree, this should be handled in your tree and Axel's patch, "ARM: exynos4: Fix build error" is too.
Hi Kukjin,
No problem, I'll take these through my tree and send a pull request to
Russell.
Cheers,
M.
--
Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: exynos4: Fix build error due to 'gic_bank_offset' undeclared
Date: Fri, 02 Dec 2011 09:24:38 +0000 [thread overview]
Message-ID: <4ED89956.9060908@arm.com> (raw)
In-Reply-To: <04f701ccb0ce$7c044d30$740ce790$%kim@samsung.com>
On 02/12/11 08:43, Kukjin Kim wrote:
> Marc Zyngier wrote:
>>
>> On 01/12/11 15:24, Axel Lin wrote:
>>> Fix below build error:
>>> CC arch/arm/mach-exynos/cpu.o
>>> arch/arm/mach-exynos/cpu.c: In function 'exynos4_init_irq':
>>> arch/arm/mach-exynos/cpu.c:245: error: 'gic_bank_offset' undeclared
>> (first use in this function)
>>> arch/arm/mach-exynos/cpu.c:245: error: (Each undeclared identifier is
>> reported only once
>>> arch/arm/mach-exynos/cpu.c:245: error: for each function it appears in.)
>>> arch/arm/mach-exynos/cpu.c:243: warning: unused variable 'bank_offset'
>>> make[1]: *** [arch/arm/mach-exynos/cpu.o] Error 1
>>> make: *** [arch/arm/mach-exynos] Error 2
>>>
>>> Signed-off-by: Axel Lin <axel.lin@gmail.com>
>>
>> Arghhh... My bad. Thanks for fixing that.
>>
>> Acked-by: Marc Zyngier <marc.zyngier@arm.com>
>>
> Hi Marc,
>
> Since the commit 4e44d2cb("ARM: exynos4: convert to CONFIG_MULTI_IRQ_HANDLER") is not in my tree, this should be handled in your tree and Axel's patch, "ARM: exynos4: Fix build error" is too.
Hi Kukjin,
No problem, I'll take these through my tree and send a pull request to
Russell.
Cheers,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2011-12-02 9:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-01 15:24 [PATCH 1/2] ARM: exynos4: Fix build error due to 'gic_bank_offset' undeclared Axel Lin
2011-12-01 15:24 ` Axel Lin
2011-12-01 15:25 ` [PATCH 2/2] ARM: exynos4: Fix build error Axel Lin
2011-12-01 15:25 ` Axel Lin
2011-12-01 16:39 ` [PATCH 1/2] ARM: exynos4: Fix build error due to 'gic_bank_offset' undeclared Marc Zyngier
2011-12-01 16:39 ` Marc Zyngier
2011-12-02 8:43 ` Kukjin Kim
2011-12-02 8:43 ` Kukjin Kim
2011-12-02 9:24 ` Marc Zyngier [this message]
2011-12-02 9:24 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED89956.9060908@arm.com \
--to=marc.zyngier@arm.com \
--cc=axel.lin@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.