From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Ming Lei <ming.lei@canonical.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
Tony Lindgren <tony@atomide.com>, Greg KH <greg@kroah.com>,
linux-kernel@vger.kernel.org,
Sylwester Nawrocki <snjw23@gmail.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH v1 2/7] omap4: build fdif omap device from hwmod
Date: Fri, 02 Dec 2011 16:10:17 +0400 [thread overview]
Message-ID: <4ED8C029.7000004@ru.mvista.com> (raw)
In-Reply-To: <1322817178-8931-3-git-send-email-ming.lei@canonical.com>
Hello.
On 02-12-2011 13:12, Ming Lei wrote:
> Signed-off-by: Ming Lei<ming.lei@canonical.com>
> ---
> arch/arm/mach-omap2/devices.c | 33 +++++++++++++++++++++++++++++++++
> 1 files changed, 33 insertions(+), 0 deletions(-)
> diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> index 1166bdc..a392af5 100644
> --- a/arch/arm/mach-omap2/devices.c
> +++ b/arch/arm/mach-omap2/devices.c
> @@ -728,6 +728,38 @@ void __init omap242x_init_mmc(struct omap_mmc_platform_data **mmc_data)
>
> #endif
>
> +static struct platform_device* __init omap4_init_fdif(void)
Shouldn't there be space before *? checkpatch.pl is silent about it?
ALso, I'd have placed '__init' after 'static'...
> +{
> + int id = -1;
> + struct platform_device *pd;
> + struct omap_hwmod *oh;
> + const char *dev_name = "fdif";
Why you need this variable at all?
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sshtylyov@ru.mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v1 2/7] omap4: build fdif omap device from hwmod
Date: Fri, 02 Dec 2011 16:10:17 +0400 [thread overview]
Message-ID: <4ED8C029.7000004@ru.mvista.com> (raw)
In-Reply-To: <1322817178-8931-3-git-send-email-ming.lei@canonical.com>
Hello.
On 02-12-2011 13:12, Ming Lei wrote:
> Signed-off-by: Ming Lei<ming.lei@canonical.com>
> ---
> arch/arm/mach-omap2/devices.c | 33 +++++++++++++++++++++++++++++++++
> 1 files changed, 33 insertions(+), 0 deletions(-)
> diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> index 1166bdc..a392af5 100644
> --- a/arch/arm/mach-omap2/devices.c
> +++ b/arch/arm/mach-omap2/devices.c
> @@ -728,6 +728,38 @@ void __init omap242x_init_mmc(struct omap_mmc_platform_data **mmc_data)
>
> #endif
>
> +static struct platform_device* __init omap4_init_fdif(void)
Shouldn't there be space before *? checkpatch.pl is silent about it?
ALso, I'd have placed '__init' after 'static'...
> +{
> + int id = -1;
> + struct platform_device *pd;
> + struct omap_hwmod *oh;
> + const char *dev_name = "fdif";
Why you need this variable at all?
WBR, Sergei
next prev parent reply other threads:[~2011-12-02 12:11 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 9:12 [RFC PATCH v1 0/7] media&omap4: introduce face detection(FD) driver Ming Lei
2011-12-02 9:12 ` Ming Lei
2011-12-02 9:12 ` [RFC PATCH v1 1/7] omap4: introduce fdif(face detect module) hwmod Ming Lei
2011-12-02 9:12 ` Ming Lei
2011-12-13 2:42 ` Ming Lei
2011-12-13 2:42 ` Ming Lei
2011-12-02 9:12 ` [RFC PATCH v1 2/7] omap4: build fdif omap device from hwmod Ming Lei
2011-12-02 9:12 ` Ming Lei
2011-12-02 12:10 ` Sergei Shtylyov [this message]
2011-12-02 12:10 ` Sergei Shtylyov
2011-12-05 4:25 ` Ming Lei
2011-12-05 4:25 ` Ming Lei
2011-12-05 4:25 ` Ming Lei
2011-12-02 9:12 ` [RFC PATCH v1 3/7] media: videobuf2: move out of setting pgprot_noncached from vb2_mmap_pfn_range Ming Lei
2011-12-02 9:12 ` Ming Lei
2011-12-02 9:12 ` [RFC PATCH v1 4/7] media: videobuf2: introduce VIDEOBUF2_PAGE memops Ming Lei
2011-12-02 9:12 ` Ming Lei
2011-12-02 16:35 ` Aguirre, Sergio
2011-12-02 16:35 ` Aguirre, Sergio
2011-12-05 2:16 ` Ming Lei
2011-12-05 2:16 ` Ming Lei
2011-12-02 9:12 ` [RFC PATCH v1 5/7] media: v4l2: introduce two IOCTLs for face detection Ming Lei
2011-12-02 9:12 ` Ming Lei
2011-12-02 12:33 ` Arnd Bergmann
2011-12-02 12:33 ` Arnd Bergmann
2011-12-04 11:18 ` Ming Lei
2011-12-04 11:18 ` Ming Lei
2011-12-04 11:18 ` Ming Lei
2011-12-05 14:37 ` Arnd Bergmann
2011-12-05 14:37 ` Arnd Bergmann
2011-12-06 6:30 ` Ming Lei
2011-12-06 6:30 ` Ming Lei
2011-12-06 12:55 ` Arnd Bergmann
2011-12-06 12:55 ` Arnd Bergmann
2011-12-06 13:11 ` Ming Lei
2011-12-06 13:11 ` Ming Lei
2011-12-06 14:41 ` Arnd Bergmann
2011-12-06 14:41 ` Arnd Bergmann
2011-12-06 14:52 ` Ming Lei
2011-12-06 14:52 ` Ming Lei
2011-12-06 15:45 ` Ming Lei
2011-12-06 15:45 ` Ming Lei
2011-12-06 20:59 ` Arnd Bergmann
2011-12-06 20:59 ` Arnd Bergmann
2011-12-02 9:12 ` [RFC PATCH v1 6/7] media: video: introduce face detection driver module Ming Lei
2011-12-02 9:12 ` Ming Lei
2011-12-02 9:12 ` [RFC PATCH v1 7/7] media: video: introduce omap4 face detection module driver Ming Lei
2011-12-02 9:12 ` Ming Lei
2011-12-02 10:28 ` [RFC PATCH v1 0/7] media&omap4: introduce face detection(FD) driver Sylwester Nawrocki
2011-12-02 10:28 ` Sylwester Nawrocki
2011-12-02 14:59 ` Ming Lei
2011-12-02 14:59 ` Ming Lei
-- strict thread matches above, loose matches on Subject: below --
2011-12-02 15:02 Ming Lei
2011-12-02 15:02 ` [RFC PATCH v1 2/7] omap4: build fdif omap device from hwmod Ming Lei
2011-12-02 15:02 ` Ming Lei
2011-12-02 16:28 ` Aguirre, Sergio
2011-12-02 16:28 ` Aguirre, Sergio
2011-12-05 4:27 ` Ming Lei
2011-12-05 4:27 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED8C029.7000004@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=ming.lei@canonical.com \
--cc=snjw23@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.