From: paul.gortmaker@windriver.com (Paul Gortmaker)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: add default value for PHYS_OFFSET Kconfig setting
Date: Fri, 2 Dec 2011 11:31:50 -0500 [thread overview]
Message-ID: <4ED8FD76.3000802@windriver.com> (raw)
In-Reply-To: <20111202092124.GR26618@pengutronix.de>
On 11-12-02 04:21 AM, Uwe Kleine-K?nig wrote:
> Hello Nicolas,
>
> On Fri, Dec 02, 2011 at 12:33:26AM -0500, Nicolas Pitre wrote:
[...]
>> And it seems that at91x40 is the only defconfig with MMU=n, so the only
>> option is really to provide a default CONFIG_PHYS_OFFSET. So what about
>> this:
>>
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index e084b7e981..a24672924f 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -222,6 +222,7 @@ config NEED_MACH_MEMORY_H
>> config PHYS_OFFSET
>> hex "Physical address of main memory"
>> depends on !ARM_PATCH_PHYS_VIRT && !NEED_MACH_MEMORY_H
>> + default DRAM_BASE if !MMU
>> help
>> Please provide the physical address corresponding to the
>> location of main memory in your system.
>>
>> Eventually the DRAM_BASE config option could simply be replaced by
>> PHYS_OFFSET directly, but that's a larger change.
> I'm working on a MMU-less machine, too and had that change already in my
> working copy. I was about to commit and it send out later today.
>
> So: Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Looks fine to me as well; I had no particular attachment to the
original patch, and you guys have a much better understanding of
the specifics of the system.
Thanks,
Paul.
>
> Best regards
> Uwe
>
WARNING: multiple messages have this Message-ID (diff)
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Nicolas Pitre <nicolas.pitre@linaro.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
<linux-arm-kernel@lists.infradead.org>,
Arnd Bergmann <arnd@arndb.de>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm: add default value for PHYS_OFFSET Kconfig setting
Date: Fri, 2 Dec 2011 11:31:50 -0500 [thread overview]
Message-ID: <4ED8FD76.3000802@windriver.com> (raw)
In-Reply-To: <20111202092124.GR26618@pengutronix.de>
On 11-12-02 04:21 AM, Uwe Kleine-König wrote:
> Hello Nicolas,
>
> On Fri, Dec 02, 2011 at 12:33:26AM -0500, Nicolas Pitre wrote:
[...]
>> And it seems that at91x40 is the only defconfig with MMU=n, so the only
>> option is really to provide a default CONFIG_PHYS_OFFSET. So what about
>> this:
>>
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index e084b7e981..a24672924f 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -222,6 +222,7 @@ config NEED_MACH_MEMORY_H
>> config PHYS_OFFSET
>> hex "Physical address of main memory"
>> depends on !ARM_PATCH_PHYS_VIRT && !NEED_MACH_MEMORY_H
>> + default DRAM_BASE if !MMU
>> help
>> Please provide the physical address corresponding to the
>> location of main memory in your system.
>>
>> Eventually the DRAM_BASE config option could simply be replaced by
>> PHYS_OFFSET directly, but that's a larger change.
> I'm working on a MMU-less machine, too and had that change already in my
> working copy. I was about to commit and it send out later today.
>
> So: Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Looks fine to me as well; I had no particular attachment to the
original patch, and you guys have a much better understanding of
the specifics of the system.
Thanks,
Paul.
>
> Best regards
> Uwe
>
next prev parent reply other threads:[~2011-12-02 16:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-01 3:52 [PATCH] arm: add default value for PHYS_OFFSET Kconfig setting Paul Gortmaker
2011-12-01 3:52 ` Paul Gortmaker
2011-12-01 10:52 ` Sergei Shtylyov
2011-12-01 10:52 ` Sergei Shtylyov
2011-12-01 14:19 ` Arnd Bergmann
2011-12-01 14:19 ` Arnd Bergmann
2011-12-02 4:38 ` Paul Gortmaker
2011-12-02 4:38 ` Paul Gortmaker
2011-12-02 5:19 ` Nicolas Pitre
2011-12-02 5:19 ` Nicolas Pitre
2011-12-02 5:33 ` Nicolas Pitre
2011-12-02 5:33 ` Nicolas Pitre
2011-12-02 9:21 ` Uwe Kleine-König
2011-12-02 9:21 ` Uwe Kleine-König
2011-12-02 16:31 ` Paul Gortmaker [this message]
2011-12-02 16:31 ` Paul Gortmaker
2011-12-02 19:07 ` Uwe Kleine-König
2011-12-02 19:07 ` Uwe Kleine-König
2011-12-02 19:27 ` Nicolas Pitre
2011-12-02 19:27 ` Nicolas Pitre
2011-12-02 20:23 ` [PATCH] ARM: determine PHYS_OFFSET automatically for no-mmu configs Uwe Kleine-König
2011-12-02 20:23 ` Uwe Kleine-König
2011-12-02 22:19 ` Nicolas Pitre
2011-12-02 22:19 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED8FD76.3000802@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.