From: Scott Wood <scottwood@freescale.com>
To: Timur Tabi <timur@freescale.com>
Cc: linuxppc-dev@ozlabs.org, kumar.gala@freescale.com
Subject: Re: [PATCH 2/2] powerpc/85xx: add a 32-bit P1022DS device tree
Date: Fri, 2 Dec 2011 17:50:33 -0600 [thread overview]
Message-ID: <4ED96449.8070408@freescale.com> (raw)
In-Reply-To: <4ED96236.9030505@freescale.com>
On 12/02/2011 05:41 PM, Timur Tabi wrote:
> Scott Wood wrote:
>
>> Nothing that happens in Linux excuses handing Linux a device tree that
>> is wrong. That you need special handling in Linux indicates that this
>> is not a simple-bus.
>
> How about this:
>
> diff --git a/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi b/arch/powerpc/boot/dts
> index 16239b1..2a62edd 100644
> --- a/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi
> @@ -35,7 +35,11 @@
> &lbc {
> #address-cells = <2>;
> #size-cells = <1>;
> - compatible = "fsl,p1022-elbc", "fsl,elbc", "simple-bus";
> + /*
> + * The localbus on the P1022 is not a simple-bus because of the eLBC
> + * pin muxing when the DIU is enabled.
> + */
> + compatible = "fsl,p1022-elbc", "fsl,elbc";
> interrupts = <19 2 0 0>;
> };
>
OK.
-Scott
next prev parent reply other threads:[~2011-12-02 23:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 22:08 [PATCH 1/2] powerpc/85xx: fix localbus and PCI addresses in the P1022DS 36-bit device tree Timur Tabi
2011-12-02 22:08 ` [PATCH 2/2] powerpc/85xx: add a 32-bit P1022DS " Timur Tabi
2011-12-02 22:19 ` Scott Wood
2011-12-02 22:24 ` Timur Tabi
2011-12-02 22:34 ` Scott Wood
2011-12-02 23:41 ` Timur Tabi
2011-12-02 23:50 ` Scott Wood [this message]
2011-12-02 23:03 ` Kumar Gala
2011-12-05 23:44 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED96449.8070408@freescale.com \
--to=scottwood@freescale.com \
--cc=kumar.gala@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.