From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm, davinci: configure davinci aemif chipselects through OF
Date: Sun, 04 Dec 2011 16:25:45 +0400 [thread overview]
Message-ID: <4EDB66C9.9050302@mvista.com> (raw)
In-Reply-To: <1322991679-20947-1-git-send-email-hs@denx.de>
Hello.
On 04-12-2011 13:41, Heiko Schocher wrote:
> Signed-off-by: Heiko Schocher<hs@denx.de>
> Cc: davinci-linux-open-source at linux.davincidsp.com
> Cc: devicetree-discuss at lists.ozlabs.org
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: grant.likely at secretlab.ca
> Cc: Sekhar Nori<nsekhar@ti.com>
> Cc: Kevin Hilman<khilman@ti.com>
> Cc: Wolfgang Denk<wd@denx.de>
> diff --git a/arch/arm/mach-davinci/aemif.c b/arch/arm/mach-davinci/aemif.c
> index 1ce70a9..12c559f 100644
> --- a/arch/arm/mach-davinci/aemif.c
> +++ b/arch/arm/mach-davinci/aemif.c
[...]
> @@ -131,3 +138,99 @@ int davinci_aemif_setup_timing(struct davinci_aemif_timing *t,
> return 0;
> }
> EXPORT_SYMBOL(davinci_aemif_setup_timing);
> +
> +#if defined(CONFIG_OF)
> +static int dv_get_value(struct device_node *np, const char *name)
> +{
> + const u32 *data;
> + int len;
> +
> + data = of_get_property(np, name,&len);
> + if (data)
> + return be32_to_cpu(readl(data));
Why readl() here?! Device tree is not a peripheral device...
> +
> + return -EINVAL;
> +}
Isn't there already a standard helper for that, of_property_read_u32()?
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
To: Heiko Schocher <hs-ynQEQJNshbs@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org,
Wolfgang Denk <wd-ynQEQJNshbs@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] arm, davinci: configure davinci aemif chipselects through OF
Date: Sun, 04 Dec 2011 16:25:45 +0400 [thread overview]
Message-ID: <4EDB66C9.9050302@mvista.com> (raw)
In-Reply-To: <1322991679-20947-1-git-send-email-hs-ynQEQJNshbs@public.gmane.org>
Hello.
On 04-12-2011 13:41, Heiko Schocher wrote:
> Signed-off-by: Heiko Schocher<hs-ynQEQJNshbs@public.gmane.org>
> Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org
> Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
> Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> Cc: grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org
> Cc: Sekhar Nori<nsekhar-l0cyMroinI0@public.gmane.org>
> Cc: Kevin Hilman<khilman-l0cyMroinI0@public.gmane.org>
> Cc: Wolfgang Denk<wd-ynQEQJNshbs@public.gmane.org>
> diff --git a/arch/arm/mach-davinci/aemif.c b/arch/arm/mach-davinci/aemif.c
> index 1ce70a9..12c559f 100644
> --- a/arch/arm/mach-davinci/aemif.c
> +++ b/arch/arm/mach-davinci/aemif.c
[...]
> @@ -131,3 +138,99 @@ int davinci_aemif_setup_timing(struct davinci_aemif_timing *t,
> return 0;
> }
> EXPORT_SYMBOL(davinci_aemif_setup_timing);
> +
> +#if defined(CONFIG_OF)
> +static int dv_get_value(struct device_node *np, const char *name)
> +{
> + const u32 *data;
> + int len;
> +
> + data = of_get_property(np, name,&len);
> + if (data)
> + return be32_to_cpu(readl(data));
Why readl() here?! Device tree is not a peripheral device...
> +
> + return -EINVAL;
> +}
Isn't there already a standard helper for that, of_property_read_u32()?
WBR, Sergei
next prev parent reply other threads:[~2011-12-04 12:25 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-04 9:41 [PATCH] arm,davinci: configure davinci aemif chipselects through OF Heiko Schocher
2011-12-04 9:41 ` Heiko Schocher
2011-12-04 12:25 ` Sergei Shtylyov [this message]
2011-12-04 12:25 ` [PATCH] arm, davinci: " Sergei Shtylyov
2011-12-05 10:50 ` Heiko Schocher
2011-12-05 10:50 ` Heiko Schocher
2011-12-04 12:33 ` Sergei Shtylyov
2011-12-04 12:33 ` Sergei Shtylyov
2011-12-05 11:49 ` Heiko Schocher
2011-12-05 11:49 ` Heiko Schocher
2011-12-07 10:44 ` [PATCH] arm,davinci: " Nori, Sekhar
2011-12-07 10:44 ` Nori, Sekhar
2011-12-08 7:47 ` [PATCH] arm, davinci: " Heiko Schocher
2011-12-08 7:47 ` Heiko Schocher
2011-12-08 8:19 ` [PATCH] arm,davinci: " Nori, Sekhar
2011-12-08 8:19 ` Nori, Sekhar
2011-12-08 9:06 ` [PATCH] arm, davinci: " Heiko Schocher
2011-12-08 9:06 ` Heiko Schocher
2011-12-08 10:29 ` [PATCH] arm,davinci: " Nori, Sekhar
2011-12-08 10:29 ` Nori, Sekhar
2011-12-08 15:48 ` [PATCH] arm, davinci: " Arnd Bergmann
2011-12-08 15:48 ` Arnd Bergmann
2011-12-13 18:34 ` [PATCH] arm,davinci: " Nori, Sekhar
2011-12-13 18:34 ` Nori, Sekhar
2011-12-14 14:35 ` [PATCH] arm, davinci: " Ben Gardiner
2011-12-14 14:35 ` Ben Gardiner
2011-12-15 17:10 ` [PATCH] arm,davinci: " Nori, Sekhar
2011-12-15 17:10 ` Nori, Sekhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDB66C9.9050302@mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.