From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: Albert ARIBAUD
<albert.u.boot-LhW3hqR2+23R7s880joybQ@public.gmane.org>,
Devicetree Discuss
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
U-Boot Mailing List
<u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org>,
Jerry Van Baren
<vanbaren-He//nVnquyzQT0dZR+AlfA@public.gmane.org>,
Tom Warren <TWarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 3/6] fdt: Add fdtdec functions to read byte array
Date: Mon, 05 Dec 2011 16:54:56 -0700 [thread overview]
Message-ID: <4EDD59D0.9090607@nvidia.com> (raw)
In-Reply-To: <1322881071-11148-4-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
On 12/02/2011 07:57 PM, Simon Glass wrote:
> From: Anton Staff <robotboy-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
>
> Sometimes we don't need a full cell for each value. This provides
> a simple function to read a byte array, both with and without
> copying it.
> +const u8 *fdtdec_locate_byte_array(const void *blob, int node,
> + const char *prop_name, int count)
> +{
> + const u8 *cell;
> + int err;
> +
> + cell = get_prop_len(blob, node, prop_name, count, &err);
Isn't that called get_prop_check_min_len() now?
> + if (err)
> + return NULL;
> + return cell;
> +}
--
nvpublic
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/6] fdt: Add fdtdec functions to read byte array
Date: Mon, 05 Dec 2011 16:54:56 -0700 [thread overview]
Message-ID: <4EDD59D0.9090607@nvidia.com> (raw)
In-Reply-To: <1322881071-11148-4-git-send-email-sjg@chromium.org>
On 12/02/2011 07:57 PM, Simon Glass wrote:
> From: Anton Staff <robotboy@chromium.org>
>
> Sometimes we don't need a full cell for each value. This provides
> a simple function to read a byte array, both with and without
> copying it.
> +const u8 *fdtdec_locate_byte_array(const void *blob, int node,
> + const char *prop_name, int count)
> +{
> + const u8 *cell;
> + int err;
> +
> + cell = get_prop_len(blob, node, prop_name, count, &err);
Isn't that called get_prop_check_min_len() now?
> + if (err)
> + return NULL;
> + return cell;
> +}
--
nvpublic
next prev parent reply other threads:[~2011-12-05 23:54 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-03 2:57 [U-Boot] [PATCH 0/6] tegra: Enable keyboard with matrix keyboard driver Simon Glass
[not found] ` <1322881071-11148-1-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-03 2:57 ` [PATCH 1/6] tegra: fdt: Add keyboard controller definition Simon Glass
2011-12-03 2:57 ` [U-Boot] " Simon Glass
2011-12-03 2:57 ` [PATCH 3/6] fdt: Add fdtdec functions to read byte array Simon Glass
2011-12-03 2:57 ` [U-Boot] " Simon Glass
[not found] ` <1322881071-11148-4-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-05 23:54 ` Stephen Warren [this message]
2011-12-05 23:54 ` Stephen Warren
2011-12-06 0:27 ` Simon Glass
2011-12-06 0:27 ` [U-Boot] " Simon Glass
2011-12-03 2:57 ` [PATCH 2/6] tegra: fdt: Add keyboard definitions for Seaboard Simon Glass
2011-12-03 2:57 ` [U-Boot] " Simon Glass
[not found] ` <1322881071-11148-3-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-05 23:49 ` Stephen Warren
2011-12-05 23:49 ` [U-Boot] " Stephen Warren
2011-12-03 2:57 ` [U-Boot] [PATCH 4/6] tegra: Add tegra keyboard support Simon Glass
[not found] ` <1322881071-11148-5-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-07 22:02 ` Stephen Warren
2011-12-07 22:02 ` [U-Boot] " Stephen Warren
[not found] ` <4EDFE259.9080201-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-12-08 21:56 ` Simon Glass
2011-12-08 21:56 ` [U-Boot] " Simon Glass
[not found] ` <CAPnjgZ3AP2d7kGqawm=CyySd=y0UfXAsYr4r0TvXaX+64pdUuA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-12-12 18:00 ` Stephen Warren
2011-12-12 18:00 ` [U-Boot] " Stephen Warren
2011-12-12 18:10 ` Simon Glass
2011-12-12 18:10 ` [U-Boot] " Simon Glass
[not found] ` <CAPnjgZ1dskr04mNfdkTPVLjbv8EnJisQvt1YrYOjKSSa=AbhkA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-12-12 18:31 ` Stephen Warren
2011-12-12 18:31 ` [U-Boot] " Stephen Warren
2011-12-12 20:03 ` Simon Glass
2011-12-12 20:03 ` [U-Boot] " Simon Glass
2011-12-03 2:57 ` [U-Boot] [PATCH 5/6] tegra: Switch on console mux and use environment for console Simon Glass
2011-12-03 2:57 ` [U-Boot] [PATCH 6/6] tegra: Enable keyboard for Seaboard Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDD59D0.9090607@nvidia.com \
--to=swarren-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=TWarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=albert.u.boot-LhW3hqR2+23R7s880joybQ@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org \
--cc=vanbaren-He//nVnquyzQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.