From: Scott Wood <scottwood@freescale.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Matt Evans <matt@ozlabs.org>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
Ingo Molnar <mingo@elte.hu>, Asias He <asias.hejun@gmail.com>,
Sasha Levin <levinsasha928@gmail.com>,
Cyrill Gorcunov <gorcunov@gmail.com>
Subject: Re: [PATCH 1/8] kvm tools: Add initial SPAPR PPC64 architecture support
Date: Tue, 06 Dec 2011 18:54:15 +0000 [thread overview]
Message-ID: <4EDE64D7.7020809@freescale.com> (raw)
In-Reply-To: <CAOJsxLGSL=sqfm4WrMY5Mrs8+M0=L0BDcmjYnRyeHaoR6zTHrg@mail.gmail.com>
On 12/06/2011 12:33 PM, Pekka Enberg wrote:
> On Tue, Dec 6, 2011 at 8:03 PM, Scott Wood <scottwood@freescale.com> wrote:
>> I'm seeing a lot of double-underscores -- is this common style in KVM
>> tool? It's reserved for use by the compiler and system library. It's
>> common in the kernel (though not used like this for namespace
>> prefixes), but there's no system library involved there.
>
> Yes, they are KVM tool coding style which we took from perf. Double
> underscore _prefixes_ are reserved in userspace but there's no reason
> we can't use them in identifiers like we do.
OK, it looks like it's just C++ that also reserves non-leading double
underscores -- sorry about that.
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Matt Evans <matt@ozlabs.org>, <kvm@vger.kernel.org>,
<kvm-ppc@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Asias He <asias.hejun@gmail.com>,
Sasha Levin <levinsasha928@gmail.com>,
Cyrill Gorcunov <gorcunov@gmail.com>
Subject: Re: [PATCH 1/8] kvm tools: Add initial SPAPR PPC64 architecture support
Date: Tue, 6 Dec 2011 12:54:15 -0600 [thread overview]
Message-ID: <4EDE64D7.7020809@freescale.com> (raw)
In-Reply-To: <CAOJsxLGSL=sqfm4WrMY5Mrs8+M0=L0BDcmjYnRyeHaoR6zTHrg@mail.gmail.com>
On 12/06/2011 12:33 PM, Pekka Enberg wrote:
> On Tue, Dec 6, 2011 at 8:03 PM, Scott Wood <scottwood@freescale.com> wrote:
>> I'm seeing a lot of double-underscores -- is this common style in KVM
>> tool? It's reserved for use by the compiler and system library. It's
>> common in the kernel (though not used like this for namespace
>> prefixes), but there's no system library involved there.
>
> Yes, they are KVM tool coding style which we took from perf. Double
> underscore _prefixes_ are reserved in userspace but there's no reason
> we can't use them in identifiers like we do.
OK, it looks like it's just C++ that also reserves non-leading double
underscores -- sorry about that.
-Scott
next prev parent reply other threads:[~2011-12-06 18:54 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1323143103.git.matt@ozlabs.org>
2011-12-06 4:05 ` [PATCH 1/8] kvm tools: Add initial SPAPR PPC64 architecture support Matt Evans
2011-12-06 4:05 ` Matt Evans
2011-12-06 18:03 ` Scott Wood
2011-12-06 18:03 ` Scott Wood
2011-12-06 18:33 ` Pekka Enberg
2011-12-06 18:33 ` Pekka Enberg
2011-12-06 18:54 ` Scott Wood [this message]
2011-12-06 18:54 ` Scott Wood
2011-12-07 7:35 ` Matt Evans
2011-12-07 7:35 ` Matt Evans
2011-12-07 18:31 ` Scott Wood
2011-12-07 18:31 ` Scott Wood
2011-12-08 2:57 ` Matt Evans
2011-12-08 2:57 ` Matt Evans
2011-12-06 4:06 ` [PATCH 2/8] kvm tools: Generate SPAPR PPC64 guest device tree Matt Evans
2011-12-06 4:06 ` Matt Evans
2011-12-06 4:06 ` [PATCH 3/8] kvm tools: Add SPAPR PPC64 hcall & rtascall structure Matt Evans
2011-12-06 4:06 ` Matt Evans
2011-12-06 4:06 ` [PATCH 4/8] kvm tools: Add SPAPR PPC64 HV console Matt Evans
2011-12-06 4:06 ` Matt Evans
2011-12-06 4:06 ` [PATCH 5/8] kvm tools: Add PPC64 XICS interrupt controller support Matt Evans
2011-12-06 4:06 ` Matt Evans
2011-12-06 4:06 ` [PATCH 6/8] kvm tools: Add PPC64 PCI Host Bridge Matt Evans
2011-12-06 4:06 ` Matt Evans
2011-12-06 4:06 ` [PATCH 7/8] kvm tools: Add PPC64 kvm_cpu__emulate_io() Matt Evans
2011-12-06 4:06 ` Matt Evans
2011-12-06 4:06 ` [PATCH 8/8] kvm tools: Make virtio-pci's ioeventfd__add_event() fall Matt Evans
2011-12-06 4:06 ` [PATCH 8/8] kvm tools: Make virtio-pci's ioeventfd__add_event() fall back gracefully if ioeventfds unavailable Matt Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDE64D7.7020809@freescale.com \
--to=scottwood@freescale.com \
--cc=asias.hejun@gmail.com \
--cc=gorcunov@gmail.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=matt@ozlabs.org \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.