From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org, takuya.yoshikawa@gmail.com
Subject: Re: [PATCH 1/4] KVM: x86 emulator: Use opcode::execute for Group 2 instructions
Date: Wed, 07 Dec 2011 18:38:42 +0200 [thread overview]
Message-ID: <4EDF9692.8020400@redhat.com> (raw)
In-Reply-To: <20111206180520.af9df45d.yoshikawa.takuya@oss.ntt.co.jp>
On 12/06/2011 11:05 AM, Takuya Yoshikawa wrote:
> Group 2: C0, C1, D0, D1, D2, D3
>
> According to the SDM, the case 6 of em_grp2() should be treated as
> undefined and the opcode D2/D3 should be decoded using the SrcCL.
>
>
> emulate_2op_SrcB(ctxt, "rcr");
> break;
> case 4: /* sal/shl */
> - case 6: /* sal/shl */
> emulate_2op_SrcB(ctxt, "sal");
> break;
> case 5: /* shr */
AMD processors decode grp2 /6 as sal/shl. In any case, please don't mix
functional changes with refactoring.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-12-07 16:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 9:04 [PATCH 0/4] KVM: x86 emulator: Move em_grp from switch statement to decode table Takuya Yoshikawa
2011-12-06 9:05 ` [PATCH 1/4] KVM: x86 emulator: Use opcode::execute for Group 2 instructions Takuya Yoshikawa
2011-12-07 16:38 ` Avi Kivity [this message]
2011-12-06 9:06 ` [PATCH 2/4] KVM: x86 emulator: Use opcode::execute for Group 1A instruction Takuya Yoshikawa
2011-12-06 9:06 ` [PATCH 3/4] KVM: x86 emulator: Use opcode::execute for Group 4/5 instructions Takuya Yoshikawa
2011-12-06 9:07 ` [PATCH 4/4] KVM: x86 emulator: Use opcode::execute for Group 9 instruction Takuya Yoshikawa
2011-12-07 16:51 ` [PATCH 0/4] KVM: x86 emulator: Move em_grp from switch statement to decode table Avi Kivity
2011-12-07 16:52 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDF9692.8020400@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=takuya.yoshikawa@gmail.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.