All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Jean Delvare <khali@linux-fr.org>,
	Guenter Roeck <guenter.roeck@ericsson.com>,
	lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH] hwmon: jz4740: Staticise
Date: Thu, 08 Dec 2011 14:08:24 +0000	[thread overview]
Message-ID: <4EE0C4D8.4050106@metafoo.de> (raw)
In-Reply-To: <1323351217.3398.0.camel@phoenix>

On 12/08/2011 02:33 PM, Axel Lin wrote:
> It is not used outside this driver so no need to make the symbol global.
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

Thanks

> ---
>  drivers/hwmon/jz4740-hwmon.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hwmon/jz4740-hwmon.c b/drivers/hwmon/jz4740-hwmon.c
> index 3d7e590..5253d23 100644
> --- a/drivers/hwmon/jz4740-hwmon.c
> +++ b/drivers/hwmon/jz4740-hwmon.c
> @@ -203,7 +203,7 @@ static int __devexit jz4740_hwmon_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -struct platform_driver jz4740_hwmon_driver = {
> +static struct platform_driver jz4740_hwmon_driver = {
>  	.probe	= jz4740_hwmon_probe,
>  	.remove = __devexit_p(jz4740_hwmon_remove),
>  	.driver = {



_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars@metafoo.de>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Jean Delvare <khali@linux-fr.org>,
	Guenter Roeck <guenter.roeck@ericsson.com>,
	lm-sensors@lm-sensors.org
Subject: Re: [PATCH] hwmon: jz4740: Staticise jz4740_hwmon_driver
Date: Thu, 08 Dec 2011 15:08:24 +0100	[thread overview]
Message-ID: <4EE0C4D8.4050106@metafoo.de> (raw)
In-Reply-To: <1323351217.3398.0.camel@phoenix>

On 12/08/2011 02:33 PM, Axel Lin wrote:
> It is not used outside this driver so no need to make the symbol global.
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

Thanks

> ---
>  drivers/hwmon/jz4740-hwmon.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hwmon/jz4740-hwmon.c b/drivers/hwmon/jz4740-hwmon.c
> index 3d7e590..5253d23 100644
> --- a/drivers/hwmon/jz4740-hwmon.c
> +++ b/drivers/hwmon/jz4740-hwmon.c
> @@ -203,7 +203,7 @@ static int __devexit jz4740_hwmon_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -struct platform_driver jz4740_hwmon_driver = {
> +static struct platform_driver jz4740_hwmon_driver = {
>  	.probe	= jz4740_hwmon_probe,
>  	.remove = __devexit_p(jz4740_hwmon_remove),
>  	.driver = {



  reply	other threads:[~2011-12-08 14:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-08 13:33 [lm-sensors] [PATCH] hwmon: jz4740: Staticise jz4740_hwmon_driver Axel Lin
2011-12-08 13:33 ` Axel Lin
2011-12-08 14:08 ` Lars-Peter Clausen [this message]
2011-12-08 14:08   ` Lars-Peter Clausen
2011-12-08 14:21 ` [lm-sensors] [PATCH] hwmon: jz4740: Staticise Guenter Roeck
2011-12-08 14:21   ` [PATCH] hwmon: jz4740: Staticise jz4740_hwmon_driver Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE0C4D8.4050106@metafoo.de \
    --to=lars@metafoo.de \
    --cc=axel.lin@gmail.com \
    --cc=guenter.roeck@ericsson.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.