From: Lars-Peter Clausen <lars@metafoo.de>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Anton Vorontsov <cbouatmailru@gmail.com>
Subject: Re: [PATCH 2/2] jz4740-battery: fix signedness bug
Date: Thu, 08 Dec 2011 15:08:49 +0100 [thread overview]
Message-ID: <4EE0C4F1.9080607@metafoo.de> (raw)
In-Reply-To: <1323349526.2823.2.camel@phoenix>
On 12/08/2011 02:05 PM, Axel Lin wrote:
> wait_for_completion_interruptible_timeout() may return negative value.
> In this case, checking if (t > 0) will return true if t is unsigned.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks
> ---
> drivers/power/jz4740-battery.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/power/jz4740-battery.c b/drivers/power/jz4740-battery.c
> index 763f894..5bb1ddd 100644
> --- a/drivers/power/jz4740-battery.c
> +++ b/drivers/power/jz4740-battery.c
> @@ -67,7 +67,7 @@ static irqreturn_t jz_battery_irq_handler(int irq, void *devid)
>
> static long jz_battery_read_voltage(struct jz_battery *battery)
> {
> - unsigned long t;
> + long t;
> unsigned long val;
> long voltage;
>
next prev parent reply other threads:[~2011-12-08 14:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 13:04 [lm-sensors] [PATCH 1/2] hwmon: jz4740: fix signedness bug Axel Lin
2011-12-08 13:04 ` Axel Lin
2011-12-08 13:05 ` [PATCH 2/2] jz4740-battery: " Axel Lin
2011-12-08 14:08 ` Lars-Peter Clausen [this message]
2012-01-06 1:57 ` Anton Vorontsov
2011-12-08 14:08 ` [lm-sensors] [PATCH 1/2] hwmon: jz4740: " Lars-Peter Clausen
2011-12-08 14:08 ` Lars-Peter Clausen
2011-12-08 14:20 ` [lm-sensors] " Guenter Roeck
2011-12-08 14:20 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE0C4F1.9080607@metafoo.de \
--to=lars@metafoo.de \
--cc=axel.lin@gmail.com \
--cc=cbouatmailru@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.