From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Jean Delvare <khali@linux-fr.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH 1/2] hwmon: jz4740: fix signedness bug
Date: Thu, 08 Dec 2011 14:20:52 +0000 [thread overview]
Message-ID: <20111208142052.GA8163@ericsson.com> (raw)
In-Reply-To: <1323349452.2823.1.camel@phoenix>
On Thu, Dec 08, 2011 at 08:04:12AM -0500, Axel Lin wrote:
> wait_for_completion_interruptible_timeout() may return negative value.
> In this case, checking if (t > 0) will return true if t is unsigned.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Jean Delvare <khali@linux-fr.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>
Subject: Re: [PATCH 1/2] hwmon: jz4740: fix signedness bug
Date: Thu, 8 Dec 2011 06:20:52 -0800 [thread overview]
Message-ID: <20111208142052.GA8163@ericsson.com> (raw)
In-Reply-To: <1323349452.2823.1.camel@phoenix>
On Thu, Dec 08, 2011 at 08:04:12AM -0500, Axel Lin wrote:
> wait_for_completion_interruptible_timeout() may return negative value.
> In this case, checking if (t > 0) will return true if t is unsigned.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied.
Thanks,
Guenter
next prev parent reply other threads:[~2011-12-08 14:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 13:04 [lm-sensors] [PATCH 1/2] hwmon: jz4740: fix signedness bug Axel Lin
2011-12-08 13:04 ` Axel Lin
2011-12-08 13:05 ` [PATCH 2/2] jz4740-battery: " Axel Lin
2011-12-08 14:08 ` Lars-Peter Clausen
2012-01-06 1:57 ` Anton Vorontsov
2011-12-08 14:08 ` [lm-sensors] [PATCH 1/2] hwmon: jz4740: " Lars-Peter Clausen
2011-12-08 14:08 ` Lars-Peter Clausen
2011-12-08 14:20 ` Guenter Roeck [this message]
2011-12-08 14:20 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111208142052.GA8163@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=axel.lin@gmail.com \
--cc=khali@linux-fr.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.