All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kyle Manna <kyle.manna@fuel7.com>
To: Steve Sakoman <sakoman@gmail.com>
Cc: lm-sensors@lm-sensors.org, linux-omap@vger.kernel.org,
	Keerthy <j-keerthy@ti.com>
Subject: Re: [PATCH RFC] mfd: twl4030-madc: Enable ADC channels 3-6
Date: Fri, 09 Dec 2011 00:38:01 -0600	[thread overview]
Message-ID: <4EE1ACC9.5000404@fuel7.com> (raw)
In-Reply-To: <CAGDS+n=QJNjCyfQ2zvPweC=aBDWt=n+y1ccgTAafqJCYt991yg@mail.gmail.com>

On 12/08/2011 05:13 PM, Steve Sakoman wrote:
> Currently the driver does not explicitly set the TWL4030_USB_SEL_MADC_MCPC
> bit to enable madc input channels 3 through 6.  This results in readings near
> zero for these channels since the inputs are grounded if this bit is not set.

I've run into this same problem and have fixed it the same way, looks 
good to me.

Reviewed-by: Kyle Manna <kyle@kylemanna.com>

- Kyle

WARNING: multiple messages have this Message-ID (diff)
From: Kyle Manna <kyle.manna@fuel7.com>
To: Steve Sakoman <sakoman@gmail.com>
Cc: lm-sensors@lm-sensors.org, linux-omap@vger.kernel.org,
	Keerthy <j-keerthy@ti.com>
Subject: Re: [lm-sensors] [PATCH RFC] mfd: twl4030-madc: Enable ADC channels
Date: Fri, 09 Dec 2011 06:38:01 +0000	[thread overview]
Message-ID: <4EE1ACC9.5000404@fuel7.com> (raw)
In-Reply-To: <CAGDS+n=QJNjCyfQ2zvPweC=aBDWt=n+y1ccgTAafqJCYt991yg@mail.gmail.com>

On 12/08/2011 05:13 PM, Steve Sakoman wrote:
> Currently the driver does not explicitly set the TWL4030_USB_SEL_MADC_MCPC
> bit to enable madc input channels 3 through 6.  This results in readings near
> zero for these channels since the inputs are grounded if this bit is not set.

I've run into this same problem and have fixed it the same way, looks 
good to me.

Reviewed-by: Kyle Manna <kyle@kylemanna.com>

- Kyle

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2011-12-09  6:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-08 23:13 [PATCH RFC] mfd: twl4030-madc: Enable ADC channels 3-6 Steve Sakoman
2011-12-08 23:13 ` [lm-sensors] " Steve Sakoman
2011-12-09  6:38 ` Kyle Manna [this message]
2011-12-09  6:38   ` [lm-sensors] [PATCH RFC] mfd: twl4030-madc: Enable ADC channels Kyle Manna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE1ACC9.5000404@fuel7.com \
    --to=kyle.manna@fuel7.com \
    --cc=j-keerthy@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=sakoman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.