From: "Arend van Spriel" <arend@broadcom.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Larry Finger" <Larry.Finger@lwfinger.net>,
"Francesco Gringoli" <francesco.gringoli@ing.unibs.it>,
b43-dev <b43-dev@lists.infradead.org>,
wireless <linux-wireless@vger.kernel.org>
Subject: Re: Performance of BCM43224 (14e4:4353)
Date: Sat, 10 Dec 2011 12:04:43 +0100 [thread overview]
Message-ID: <4EE33CCB.80309@broadcom.com> (raw)
In-Reply-To: <CACna6rzQuw+oMvYjN6+7SsTqqW=vFFj8W1iuwDY8x+p+GgJ6jA@mail.gmail.com>
On 12/10/2011 10:18 AM, Rafał Miłecki wrote:
> 2011/12/9 Larry Finger <Larry.Finger@lwfinger.net>:
>> On 12/09/2011 02:04 PM, Arend van Spriel wrote:
>>>
>>>
>>> Indeed. What is more strange is that this looks like value from
>>> enumeration rom. 0x4bf is BCMA_MANUF_BCM, 0x800 is BCMA_CORE_CHIPCOMMON.
>>> It seems the BAR window is wrong. Can you read PCI_BAR window in the
>>> ai_doattach() before reading the chip id.
>>
>>
>> I would like a hint on how to do this. I tried some things that failed.
>
> Have you tried
> u32 value;
> pci_write_config_dword(core->bus->host_pci, BCMA_PCI_BAR0_WIN, &value);
> pr_info();
> pci_write_config_dword(core->bus->host_pci, BCMA_PCI_BAR0_WIN2, &value);
> pr_info();
>
> You should also hack bcma_bus_scan to display addr and wrap.
> pr_info("Core %d addr: 0x%X, wrap 0x%X\n", core->core_index,
> core->addr, core->wrap);
> (put is inside the while, after existing pr_info)
>
Obviously it should be a pci_read_config_dword(). I found out that I can
reproduce the problem over here so I added the print statements:
[61359.893254] brcmsmac bcma0:0: mfg 4bf core 812 rev 23 class 0 irq 17
[61359.897801] core[2] id=0x820 addr=18002000 wrap=18102000
[61359.897808] core[1] id=0x812 addr=18001000 wrap=18101000
[61359.897814] core[0] id=0x800 addr=18000000 wrap=18100000
[61359.897822] PCI_BAR0_WIN=18107000
Not sure how it got programmed to this value, but it definitely is wrong.
Gr. AvS
next prev parent reply other threads:[~2011-12-10 11:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 0:46 Performance of BCM43224 (14e4:4353) Larry Finger
2011-12-09 9:16 ` Arend van Spriel
2011-12-09 10:27 ` Arend van Spriel
2011-12-09 16:44 ` Larry Finger
2011-12-09 16:44 ` Larry Finger
2011-12-09 17:32 ` Arend van Spriel
2011-12-09 17:57 ` Larry Finger
2011-12-09 17:57 ` Larry Finger
2011-12-09 19:31 ` Arend van Spriel
2011-12-09 20:06 ` Larry Finger
2011-12-09 20:06 ` Larry Finger
2011-12-09 18:17 ` Larry Finger
2011-12-09 18:17 ` Larry Finger
2011-12-09 20:04 ` Arend van Spriel
2011-12-09 22:53 ` Larry Finger
2011-12-09 22:53 ` Larry Finger
2011-12-10 9:18 ` Rafał Miłecki
2011-12-10 9:18 ` Rafał Miłecki
2011-12-10 11:04 ` Arend van Spriel [this message]
2011-12-10 19:49 ` Larry Finger
2011-12-10 19:49 ` Larry Finger
2011-12-10 20:28 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE33CCB.80309@broadcom.com \
--to=arend@broadcom.com \
--cc=Larry.Finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=francesco.gringoli@ing.unibs.it \
--cc=linux-wireless@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.