All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fredrik Lingvall <fredrik.lingvall@gmail.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: linux-media@vger.kernel.org
Subject: Re: Hauppauge HVR-930C problems
Date: Sat, 10 Dec 2011 14:43:23 +0100	[thread overview]
Message-ID: <4EE361FB.9090301@gmail.com> (raw)
In-Reply-To: <4EE0D169.5040607@redhat.com>

On 12/08/11 16:02, Mauro Carvalho Chehab wrote:
>
>> #!/bin/bash
>> for i in `seq 1 20`;
>> do
>> w_scan -fc -c NO 1>> scan$i.log 2>> scan$i.log
>> done
>>
>> And I get outputs like this (the timing numbers differs of course 
>> somewhat between different runs):
>>
>> <snip>
>>
>> 586000: sr6900 (time: 10:21) sr6875 (time: 10:23)
>> 594000: sr6900 (time: 10:26) sr6875 (time: 10:28)
>> 602000: sr6900 (time: 10:31) (time: 10:32) signal ok:
>> QAM_256 f = 602000 kHz S6900C999
>> Info: NIT(actual) filter timeout
>> 610000: sr6900 (time: 10:44) sr6875 (time: 10:47)
>> 618000: sr6900 (time: 10:49) sr6875 (time: 10:52)
>> 626000: sr6900 (time: 10:54) sr6875 (time: 10:57)
>>
>> <snip>
>>
>> Then I did the test that you suggested:
>>
>> lin-tv ~ # strace -e ioctl dvbscan -fc test_channel_file
>>
>> scanning test_channel_file
>> using '/dev/dvb/adapter0/frontend0' and '/dev/dvb/adapter0/demux0'
>> ioctl(3, FE_GET_INFO, 0x60b180) = 0
>> initial transponder 602000000 6900000 0 5
>> >>> tune to: 602000000:INVERSION_AUTO:6900000:FEC_NONE:QAM_256
>> ioctl(3, FE_SET_FRONTEND, 0x7fff0581fb20) = 0
>> ioctl(3, FE_READ_STATUS, 0x7fff0581fb4c) = 0
>> ioctl(3, FE_READ_STATUS, 0x7fff0581fb4c) = 0
>> ioctl(4, DMX_SET_FILTER, 0x7fff0581e930) = 0
>> ioctl(5, DMX_SET_FILTER, 0x7fff0581e930) = 0
>> ioctl(6, DMX_SET_FILTER, 0x7fff0581e930) = 0
>> WARNING: filter timeout pid 0x0011
>> ioctl(5, DMX_STOP, 0x23) = 0
>> WARNING: filter timeout pid 0x0000
>> ioctl(4, DMX_STOP, 0x23) = 0
>> WARNING: filter timeout pid 0x0010
>> ioctl(6, DMX_STOP, 0x23) = 0
>> dumping lists (0 services)
>> Done.
>>
>>
>> I did not get the:
>>
>> 602000: sr6900 (time: 10:32) (time: 10:33) signal ok:
>> QAM_256 f = 602000 kHz S6900C999
>> start_filter:1415: ERROR: ioctl DMX_SET_FILTER failed: 28 No space 
>> left on device
>
>
>> Info: NIT(actual) filter timeout
>>
>> that I got before. The changes I made from before was 1) I unmounted 
>> the USB disk and 2) I rebuild the xc5000 module where I removed the
>>
>> mutex_lock(&xc5000_list_mutex);
>>
>> and
>>
>> mutex_unlock(&xc5000_list_mutex);
>>
>> lines according to the discussion in the " ... em28xx: initial 
>> support for HAUPPAUGE HVR-930C again" thread.
>
> Ok, let's go by parts.
>
> 1) error 28 at DMX_SET_FILTER is really due to lack of space at the 
> USB bus. I've
> double-checked at the code. The only place there where it could occur 
> is when
> dvb_dmxdev_feed_start() calls feed->ts->start_filtering(feed->ts), 
> with should be
> pointing to em28xx_start_feed(), with tries to start the transfer 
> URB's at
> em28xx_init_isoc() by calling usb_submit_urb(). This is the only 
> routine that returns
> ENOSPC on this chain.
>
> It is very likely that what fixed it were the removal of the USB disk.
>
> 2)  There is an error at the bandwidth calculus on xc5000. It is 
> likely that it is
> using a 6MHz bandwidth filter, instead of a 8MHz one.
>
> Please try the enclosed patch.
>
>
> [media] xc5000,tda18271c2dd: Fix bandwidth calculus
>     Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>
> diff --git a/drivers/media/common/tuners/xc5000.c 
> b/drivers/media/common/tuners/xc5000.c
> index ecd1f95..8279c45 100644
> --- a/drivers/media/common/tuners/xc5000.c
> +++ b/drivers/media/common/tuners/xc5000.c
> @@ -708,9 +708,9 @@ static int xc5000_set_params(struct dvb_frontend *fe,
>               * is equal to 0.15 for Annex A, and 0.13 for annex C
>               */
>              if (fe->dtv_property_cache.rolloff == ROLLOFF_13)
> -                bw = (params->u.qam.symbol_rate * 13) / 10;
> +                bw = (params->u.qam.symbol_rate * 113) / 100;
>              else
> -                bw = (params->u.qam.symbol_rate * 15) / 10;
> +                bw = (params->u.qam.symbol_rate * 115) / 100;
>              if (bw <= 6000000) {
>                  priv->bandwidth = BANDWIDTH_6_MHZ;
>                  priv->video_standard = DTV6;
> diff --git a/drivers/media/dvb/frontends/tda18271c2dd.c 
> b/drivers/media/dvb/frontends/tda18271c2dd.c
> index de544f6..b66ca29 100644
> --- a/drivers/media/dvb/frontends/tda18271c2dd.c
> +++ b/drivers/media/dvb/frontends/tda18271c2dd.c
> @@ -1158,9 +1158,9 @@ static int set_params(struct dvb_frontend *fe,
>           * is equal to 0.15 for Annex A, and 0.13 for annex C
>           */
>          if (fe->dtv_property_cache.rolloff == ROLLOFF_13)
> -            bw = (params->u.qam.symbol_rate * 13) / 10;
> +            bw = (params->u.qam.symbol_rate * 113) / 100;
>          else
> -            bw = (params->u.qam.symbol_rate * 15) / 10;
> +            bw = (params->u.qam.symbol_rate * 115) / 100;
>          if (bw <= 6000000)
>              Standard = HF_DVBC_6MHZ;
>          else if (bw <= 7000000)
>
>

Changing 13 -> 113 and 15 -> 115 in the two files made no difference. 
However, I figured out that the

586000: sr6900 (time: 10:22) sr6875 (time: 10:24)
594000: sr6900 (time: 10:27) sr6875 (time: 10:30)
602000: sr6900 (time: 10:32) (time: 10:33) signal ok:
         QAM_256  f = 602000 kHz S6900C999
start_filter:1417: ERROR: ioctl DMX_SET_FILTER failed: 28 No space left 
on device
Info: NIT(actual) filter timeout
610000: sr6900 (time: 10:55) sr6875 (time: 10:57)
618000: sr6900 (time: 11:00) sr6875 (time: 11:02)
626000: sr6900 (time: 11:05) sr6875 (time: 11:07)

output from w_scan only happends the first time after the driver has 
been loaded. That is, running this script

#!/bin/bash
for i in `seq 1 20`;
do
     rmmod em28xx_dvb
     rmmod em28xx
     sleep 5
     modprobe em28xx
     sleep 5
     echo $i
     w_scan -fc -c NO 1>> scan_out$i.log 2>> scan_err$i.log
done

will give the error above for every scan but if I don't reload the 
driver then I will get the output:

594000: sr6900 (time: 10:26) sr6875 (time: 10:29)
602000: sr6900 (time: 10:31) (time: 10:32) signal ok:
         QAM_256  f = 602000 kHz S6900C999
Info: NIT(actual) filter timeout
610000: sr6900 (time: 10:45) sr6875 (time: 10:47)
618000: sr6900 (time: 10:50) sr6875 (time: 10:52)

for i >=2 instead.

I noticed the new patches you are working with on the list. Let me know 
I there's something I can test?

Regards,

/Fredrik











  reply	other threads:[~2011-12-10 13:43 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-02 19:41 Hauppauge HVR-930C problems Fredrik Lingvall
2011-12-02 19:45 ` Devin Heitmueller
2011-12-05 23:37   ` Eddi De Pieri
2011-12-06  8:38     ` Fredrik Lingvall
2011-12-07 12:22     ` Mauro Carvalho Chehab
2011-12-07 12:56 ` Mauro Carvalho Chehab
2011-12-07 13:31   ` Fredrik Lingvall
2011-12-07 13:55     ` Mauro Carvalho Chehab
2011-12-07 14:25       ` Fredrik Lingvall
2011-12-07 14:54         ` Mauro Carvalho Chehab
2011-12-08  8:31           ` Fredrik Lingvall
2011-12-08 15:02             ` Mauro Carvalho Chehab
2011-12-10 13:43               ` Fredrik Lingvall [this message]
2011-12-10 16:02                 ` Mauro Carvalho Chehab
2011-12-17 17:42                   ` Fredrik Lingvall
     [not found] <CALJK-QhGrjC9K8CasrUJ-aisZh8U_4-O3uh_-dq6cNBWUx_4WA@mail.gmail.com>
2011-12-15  8:04 ` Fredrik Lingvall
2011-12-15  9:54   ` Mauro Carvalho Chehab
     [not found]   ` <CALJK-QjxDpC8Y_gPXeAJaT2si_pRREiuTW=T8CWSTxGprRhfkg@mail.gmail.com>
2011-12-16  8:20     ` Fredrik Lingvall
     [not found]       ` <CALJK-Qhpk7NtSezrft_6+4FZ7Y35k=41xrc6ebxf2DzEH6KCWw@mail.gmail.com>
     [not found]         ` <4EECB2C2.8050701@gmail.com>
2011-12-17 19:09           ` Mihai Dobrescu
     [not found]           ` <4EECE392.5080000@gmail.com>
     [not found]             ` <CALJK-QjChFbX7NH0qNhvaz=Hp8JfKENJMsLOsETiYO9ZyV_BOg@mail.gmail.com>
2011-12-17 19:59               ` Mihai Dobrescu
2011-12-18  9:20               ` Fredrik Lingvall
2011-12-25 15:56                 ` Fredrik Lingvall
2012-01-10 14:42                   ` Fredrik Lingvall
2012-01-10 19:30                     ` Mihai Dobrescu
2012-01-10 19:41                       ` Mauro Carvalho Chehab
2012-01-10 20:23                         ` Mihai Dobrescu
2012-01-10 20:35                           ` Mauro Carvalho Chehab
2012-01-11  5:28                             ` Mihai Dobrescu
2012-01-11 10:53                               ` Mauro Carvalho Chehab
2012-01-11 12:24                       ` Fredrik Lingvall
2012-01-11  9:21                     ` Fredrik Lingvall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE361FB.9090301@gmail.com \
    --to=fredrik.lingvall@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.