From: Gerd Hoffmann <kraxel@redhat.com>
To: "Cao,Bing Bu" <mars@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix parse of usb device description with multiple configurations
Date: Mon, 12 Dec 2011 09:23:28 +0100 [thread overview]
Message-ID: <4EE5BA00.7040507@redhat.com> (raw)
In-Reply-To: <1323326175-25184-1-git-send-email-mars@linux.vnet.ibm.com>
Hi,
> + } else if (descriptors[i + 5] != s->configuration) {
> + fprintf(stderr, "not requested configuration %d\n",
> + s->configuration);
> + i += (descriptors[i + 3] << 8) + descriptors[i + 2];
> + continue;
> + }
That message doesn't indicate an error and should be a DPRINTF instead
of a fprintf. Otherwise the patch looks fine.
cheers,
Gerd
prev parent reply other threads:[~2011-12-12 8:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 6:36 [Qemu-devel] [PATCH] Fix parse of usb device description with multiple configurations Cao,Bing Bu
2011-12-12 8:23 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE5BA00.7040507@redhat.com \
--to=kraxel@redhat.com \
--cc=mars@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.