From: "Andreas Färber" <afaerber@suse.de>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] vl.c: Fold constant string into printf rather than using %s
Date: Mon, 12 Dec 2011 10:40:42 +0100 [thread overview]
Message-ID: <4EE5CC1A.90506@suse.de> (raw)
In-Reply-To: <1323678104-30133-2-git-send-email-michael@ellerman.id.au>
Am 12.12.2011 09:21, schrieb Michael Ellerman:
> In help() we do what boils down to:
>
> printf("%s", "qemu");
>
> This seems to be an artifact of be995c27640a82c7056b6f53d02ec823570114e5
> ("removed unused code"), which removed some ifdef'ery that used to print
> a different name depending on CONFIG_SOFTMMU.
>
> But now that is gone and we always use "qemu" we may as well just put
> that in the format string.
I would rather propose to save argv[0] and use that. By now "qemu" is
not even correct for i386.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2011-12-12 9:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 8:14 [Qemu-devel] RFC: Only display help options that are accepted by the architecture Michael Ellerman
2011-12-12 8:21 ` [Qemu-devel] [PATCH 1/3] Add arch mask to headings but don't use it yet Michael Ellerman
2011-12-12 8:21 ` [Qemu-devel] [PATCH 2/3] vl.c: Fold constant string into printf rather than using %s Michael Ellerman
2011-12-12 9:40 ` Andreas Färber [this message]
2011-12-12 8:21 ` [Qemu-devel] [PATCH 3/3] In qemu -h output, only print options for the arch we are running as Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE5CC1A.90506@suse.de \
--to=afaerber@suse.de \
--cc=michael@ellerman.id.au \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.