All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: Igor Grinberg <grinberg@compulab.co.il>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	tony@atomide.com, neilb@suse.de
Subject: Re: [PATCH] ARM: OMAP: mcbsp: Fix possible memory corruption
Date: Mon, 12 Dec 2011 13:22:28 +0200	[thread overview]
Message-ID: <4EE5E3F4.6060701@bitmer.com> (raw)
In-Reply-To: <4EE5D639.8080608@compulab.co.il>

Hi

On 12/12/2011 12:23 PM, Igor Grinberg wrote:
> On 12/12/11 10:38, Jarkko Nikula wrote:
>> Commits 09d28d ("ARM: OMAP: mcbsp: Start generalize omap2_mcbsp_set_clks_src")
>> and 7bc0c4 ("ARM: OMAP: mcbsp: Start generalize signal muxing functions")
>> incorrectly set two struct omap_mcbsp_platform_data fields after
>> omap_device_build_ss and kfree calls.
>>
>> Fix this by moving these pdata assignments before those calls.
>>
>> Signed-off-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
>> Reported-by: neilb@suse.de
> Perhaps, should be:
> Reported-by: NeilBrown <neilb@suse.de>
> and
> Cc: <stable@vger.kernel.org>	[3.1]
> as for below.
>> ---
>> For 3.2, 3.1 is ok.
>> ---
No need to cc stable since the issue is not in stable kernels.

-- 
Jarkko

WARNING: multiple messages have this Message-ID (diff)
From: jarkko.nikula@bitmer.com (Jarkko Nikula)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP: mcbsp: Fix possible memory corruption
Date: Mon, 12 Dec 2011 13:22:28 +0200	[thread overview]
Message-ID: <4EE5E3F4.6060701@bitmer.com> (raw)
In-Reply-To: <4EE5D639.8080608@compulab.co.il>

Hi

On 12/12/2011 12:23 PM, Igor Grinberg wrote:
> On 12/12/11 10:38, Jarkko Nikula wrote:
>> Commits 09d28d ("ARM: OMAP: mcbsp: Start generalize omap2_mcbsp_set_clks_src")
>> and 7bc0c4 ("ARM: OMAP: mcbsp: Start generalize signal muxing functions")
>> incorrectly set two struct omap_mcbsp_platform_data fields after
>> omap_device_build_ss and kfree calls.
>>
>> Fix this by moving these pdata assignments before those calls.
>>
>> Signed-off-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
>> Reported-by: neilb at suse.de
> Perhaps, should be:
> Reported-by: NeilBrown <neilb@suse.de>
> and
> Cc: <stable@vger.kernel.org>	[3.1]
> as for below.
>> ---
>> For 3.2, 3.1 is ok.
>> ---
No need to cc stable since the issue is not in stable kernels.

-- 
Jarkko

  reply	other threads:[~2011-12-12 11:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-12  8:36 [PATCH] ARM: OMAP: mcbsp: Fix possible memory corruption Jarkko Nikula
2011-12-12  8:38 ` Jarkko Nikula
2011-12-12  8:38   ` Jarkko Nikula
2011-12-12 10:23   ` Igor Grinberg
2011-12-12 10:23     ` Igor Grinberg
2011-12-12 11:22     ` Jarkko Nikula [this message]
2011-12-12 11:22       ` Jarkko Nikula
2011-12-12 11:57       ` Igor Grinberg
2011-12-12 11:57         ` Igor Grinberg
2011-12-12 18:33         ` Tony Lindgren
2011-12-12 18:33           ` Tony Lindgren
2011-12-14 20:50           ` Ramirez Luna, Omar
2011-12-14 20:50             ` Ramirez Luna, Omar
2011-12-14 21:54             ` Tony Lindgren
2011-12-14 21:54               ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE5E3F4.6060701@bitmer.com \
    --to=jarkko.nikula@bitmer.com \
    --cc=grinberg@compulab.co.il \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.