From: Christoph Egger <Christoph.Egger@amd.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH] libxc: switch to XC_PAGE_*
Date: Tue, 13 Dec 2011 15:19:05 +0100 [thread overview]
Message-ID: <4EE75ED9.4030407@amd.com> (raw)
In-Reply-To: <20198.5427.127204.527798@mariner.uk.xensource.com>
On 12/12/11 15:52, Ian Jackson wrote:
> Christoph Egger writes ("[Xen-devel] [PATCH] libxc: switch to XC_PAGE_*"):
>> Switch to a consistent set of XC_PAGE_* constants.
>
> This looks reasonable to me but: can you confirm what tests you've
> done to check that this doesn't have any actual change to the code ?
Is it enough to say a guest boots and runs as before?
> Eg it would be good to run it through the preprocessor and see if the
> output is identical to before.
>
> Ian.
>
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2011-12-13 14:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 9:34 [PATCH] libxc: switch to XC_PAGE_* Christoph Egger
2011-12-12 14:52 ` Ian Jackson
2011-12-13 14:19 ` Christoph Egger [this message]
2011-12-13 14:21 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE75ED9.4030407@amd.com \
--to=christoph.egger@amd.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.