From: Joshua Lock <josh@linux.intel.com>
To: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH 01/10] command.py: Modify needcache value for certain functions
Date: Tue, 13 Dec 2011 08:31:15 -0800 [thread overview]
Message-ID: <4EE77DD3.9030205@linux.intel.com> (raw)
In-Reply-To: <a58b9713d301a6cbca3372f031a015365a57f295.1323656120.git.dongxiao.xu@intel.com>
On 11/12/11 18:20, Dongxiao Xu wrote:
> for findConfigFiels() and findFilesMatchingInDir() functions, they
> don't need to parse all the bb files, thus setting the needcache
> value to be False.
>
> Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
If we can't rely on event_data to be consistent/up-to-date do we need to
keep it around? The comment around its creation implies we want/need the
copy of data.
This feels like we're working around on issue rather than fixing one.
Joshua
> ---
> lib/bb/command.py | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/bb/command.py b/lib/bb/command.py
> index 83907f6..5dec6a9 100644
> --- a/lib/bb/command.py
> +++ b/lib/bb/command.py
> @@ -241,7 +241,7 @@ class CommandsAsync:
>
> command.cooker.findConfigFiles(varname)
> command.finishAsyncCommand()
> - findConfigFiles.needcache = True
> + findConfigFiles.needcache = False
>
> def findFilesMatchingInDir(self, command, params):
> """
> @@ -253,7 +253,7 @@ class CommandsAsync:
>
> command.cooker.findFilesMatchingInDir(pattern, directory)
> command.finishAsyncCommand()
> - findFilesMatchingInDir.needcache = True
> + findFilesMatchingInDir.needcache = False
>
> def findConfigFilePath(self, command, params):
> """
--
Joshua Lock
Yocto Project "Johannes factotum"
Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-12-13 16:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 2:20 [PATCH 00/10][PULL] Hob2 related bitbake changes Dongxiao Xu
2011-12-12 2:20 ` [PATCH 01/10] command.py: Modify needcache value for certain functions Dongxiao Xu
2011-12-13 16:31 ` Joshua Lock [this message]
2011-12-12 2:20 ` [PATCH 02/10] cache: Use configuration's hash value to validate cache Dongxiao Xu
2011-12-12 2:20 ` [PATCH 03/10] cooker: user bb.configuration.data to inject events Dongxiao Xu
2011-12-13 16:31 ` Joshua Lock
2011-12-14 1:03 ` Xu, Dongxiao
2011-12-12 2:20 ` [PATCH 04/10] command.py: add initCooker API Dongxiao Xu
2011-12-12 2:20 ` [PATCH 05/10] command.py: add parseConfigurationFiles API Dongxiao Xu
2011-12-13 16:38 ` Joshua Lock
2011-12-14 0:41 ` Xu, Dongxiao
2011-12-14 0:54 ` Joshua Lock
2011-12-12 2:20 ` [PATCH 06/10] command.py: add generateTargetsTreePro API Dongxiao Xu
2011-12-13 16:46 ` Joshua Lock
2011-12-14 0:44 ` Xu, Dongxiao
2011-12-12 2:20 ` [PATCH 07/10] event.py: Add a new event PackageInfo Dongxiao Xu
2011-12-12 2:20 ` [PATCH 08/10] xmlrpc: Change BitbakeServerInfo init function Dongxiao Xu
2011-12-12 2:20 ` [PATCH 09/10] cooker: remove command import in cooker.py Dongxiao Xu
2011-12-12 2:20 ` [PATCH 10/10] bitbake: add a new option "--server-only" Dongxiao Xu
-- strict thread matches above, loose matches on Subject: below --
2011-12-15 7:14 [PATCH 00/10 v2] Hob2 related bitbake changes Dongxiao Xu
2011-12-15 7:14 ` [PATCH 01/10] command.py: Modify needcache value for certain functions Dongxiao Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE77DD3.9030205@linux.intel.com \
--to=josh@linux.intel.com \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.