All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joshua Lock <josh@linux.intel.com>
To: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH 05/10] command.py: add parseConfigurationFiles API
Date: Tue, 13 Dec 2011 08:38:34 -0800	[thread overview]
Message-ID: <4EE77F8A.5030900@linux.intel.com> (raw)
In-Reply-To: <5e6bb33f07469e4ee3925104c8ee4e3036a3cee4.1323656120.git.dongxiao.xu@intel.com>

On 11/12/11 18:20, Dongxiao Xu wrote:
> The parseConfigurationFiles API calls the related function in
> cooker.py to parse config files.
> 
> Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
> ---
>  lib/bb/command.py |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/lib/bb/command.py b/lib/bb/command.py
> index 701b286..6b4a598 100644
> --- a/lib/bb/command.py
> +++ b/lib/bb/command.py
> @@ -326,3 +326,13 @@ class CommandsAsync:
>          else:
>              command.finishAsyncCommand()
>      compareRevisions.needcache = True
> +
> +    def parseConfigurationFiles(self, command, params):
> +        """
> +        Parse the configuration files
> +        """
> +        prefiles = params[0]
> +        postfiles = params[1]

Should we be able to use this method without having prefiles and
postfiles set in the params container?

A common pattern throughout this module is to check the size of the
params container [using len(params)] and set appropriate (empty)
defaults if all required parameters aren't passed.

Cheers,
Joshua
-- 
Joshua Lock
        Yocto Project "Johannes factotum"
        Intel Open Source Technology Centre



  reply	other threads:[~2011-12-13 16:45 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-12  2:20 [PATCH 00/10][PULL] Hob2 related bitbake changes Dongxiao Xu
2011-12-12  2:20 ` [PATCH 01/10] command.py: Modify needcache value for certain functions Dongxiao Xu
2011-12-13 16:31   ` Joshua Lock
2011-12-12  2:20 ` [PATCH 02/10] cache: Use configuration's hash value to validate cache Dongxiao Xu
2011-12-12  2:20 ` [PATCH 03/10] cooker: user bb.configuration.data to inject events Dongxiao Xu
2011-12-13 16:31   ` Joshua Lock
2011-12-14  1:03     ` Xu, Dongxiao
2011-12-12  2:20 ` [PATCH 04/10] command.py: add initCooker API Dongxiao Xu
2011-12-12  2:20 ` [PATCH 05/10] command.py: add parseConfigurationFiles API Dongxiao Xu
2011-12-13 16:38   ` Joshua Lock [this message]
2011-12-14  0:41     ` Xu, Dongxiao
2011-12-14  0:54       ` Joshua Lock
2011-12-12  2:20 ` [PATCH 06/10] command.py: add generateTargetsTreePro API Dongxiao Xu
2011-12-13 16:46   ` Joshua Lock
2011-12-14  0:44     ` Xu, Dongxiao
2011-12-12  2:20 ` [PATCH 07/10] event.py: Add a new event PackageInfo Dongxiao Xu
2011-12-12  2:20 ` [PATCH 08/10] xmlrpc: Change BitbakeServerInfo init function Dongxiao Xu
2011-12-12  2:20 ` [PATCH 09/10] cooker: remove command import in cooker.py Dongxiao Xu
2011-12-12  2:20 ` [PATCH 10/10] bitbake: add a new option "--server-only" Dongxiao Xu
  -- strict thread matches above, loose matches on Subject: below --
2011-12-15  7:14 [PATCH 00/10 v2] Hob2 related bitbake changes Dongxiao Xu
2011-12-15  7:14 ` [PATCH 05/10] command.py: add parseConfigurationFiles API Dongxiao Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE77F8A.5030900@linux.intel.com \
    --to=josh@linux.intel.com \
    --cc=bitbake-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.