From: Anthony Liguori <anthony@codemonkey.ws>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: David Gibson <dwg@au1.ibm.com>, Alexander Graf <agraf@suse.de>,
kvm-ppc@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] spapr: Add support for -vga option
Date: Thu, 15 Dec 2011 00:10:50 +0000 [thread overview]
Message-ID: <4EE93B0A.1000703@codemonkey.ws> (raw)
In-Reply-To: <1323907246.21839.29.camel@pasglop>
On 12/14/2011 06:00 PM, Benjamin Herrenschmidt wrote:
> On Wed, 2011-12-14 at 15:48 -0600, Anthony Liguori wrote:
>>> /* USB */
>>> if (usb_enabled) {
>>>
>> usb_ohci_init_pci(QLIST_FIRST(&spapr->phbs)->host_state.bus, -1);
>>> + if (spapr_has_graphics) {
>>> + usbdevice_create("keyboard");
>>> + usbdevice_create("mouse");
>>
>> It is better to use usb_create() and pass it the usb bus directly as
>> this will make it easier to express this as composition down the road.
>
> How do I do that ? usb_ohci_init_pci() doesn't appear to return
> the USB bus....
Let's make it... I'll send a patch.
Regards,
Anthony Liguori
>
> Cheers,
> Ben.
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <anthony@codemonkey.ws>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: David Gibson <dwg@au1.ibm.com>, Alexander Graf <agraf@suse.de>,
kvm-ppc@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] spapr: Add support for -vga option
Date: Wed, 14 Dec 2011 18:10:50 -0600 [thread overview]
Message-ID: <4EE93B0A.1000703@codemonkey.ws> (raw)
In-Reply-To: <1323907246.21839.29.camel@pasglop>
On 12/14/2011 06:00 PM, Benjamin Herrenschmidt wrote:
> On Wed, 2011-12-14 at 15:48 -0600, Anthony Liguori wrote:
>>> /* USB */
>>> if (usb_enabled) {
>>>
>> usb_ohci_init_pci(QLIST_FIRST(&spapr->phbs)->host_state.bus, -1);
>>> + if (spapr_has_graphics) {
>>> + usbdevice_create("keyboard");
>>> + usbdevice_create("mouse");
>>
>> It is better to use usb_create() and pass it the usb bus directly as
>> this will make it easier to express this as composition down the road.
>
> How do I do that ? usb_ohci_init_pci() doesn't appear to return
> the USB bus....
Let's make it... I'll send a patch.
Regards,
Anthony Liguori
>
> Cheers,
> Ben.
>
>
>
next prev parent reply other threads:[~2011-12-15 0:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 9:22 [PATCH] spapr: Add support for -vga option Benjamin Herrenschmidt
2011-12-14 9:22 ` [Qemu-devel] " Benjamin Herrenschmidt
2011-12-14 15:30 ` Paolo Bonzini
2011-12-14 15:30 ` [Qemu-devel] " Paolo Bonzini
2011-12-14 20:04 ` Benjamin Herrenschmidt
2011-12-14 20:04 ` [Qemu-devel] " Benjamin Herrenschmidt
2011-12-14 21:48 ` Anthony Liguori
2011-12-14 21:48 ` Anthony Liguori
2011-12-15 0:00 ` Benjamin Herrenschmidt
2011-12-15 0:00 ` Benjamin Herrenschmidt
2011-12-15 0:10 ` Anthony Liguori [this message]
2011-12-15 0:10 ` Anthony Liguori
2011-12-23 5:36 ` Benjamin Herrenschmidt
2011-12-23 5:36 ` [Qemu-devel] " Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE93B0A.1000703@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=agraf@suse.de \
--cc=benh@kernel.crashing.org \
--cc=dwg@au1.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.