[PATCH 8/15] apparmor: fix module parameter handling

[PATCH 8/15] apparmor: fix module parameter handling

[Rusty Russell]

The 'aabool' wrappers actually pass off to the 'bool' parse functions,
so you should use the same check function.  Similarly for aauint and
uint.

(Note that 'bool' module parameters also allow 'int', which is why you
got away with this, but that's changing very soon.)

Cc: John Johansen <john.johansen@canonical.com>
Cc: James Morris <jmorris@namei.org>
Cc: linux-security-module@vger.kernel.org
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---
 security/apparmor/lsm.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
--- a/security/apparmor/lsm.c
+++ b/security/apparmor/lsm.c
@@ -671,7 +671,7 @@ static struct security_operations apparm
 
 static int param_set_aabool(const char *val, const struct kernel_param *kp);
 static int param_get_aabool(char *buffer, const struct kernel_param *kp);
-#define param_check_aabool(name, p) __param_check(name, p, int)
+#define param_check_aabool param_check_bool
 static struct kernel_param_ops param_ops_aabool = {
 	.set = param_set_aabool,
 	.get = param_get_aabool
@@ -679,7 +679,7 @@ static struct kernel_param_ops param_ops
 
 static int param_set_aauint(const char *val, const struct kernel_param *kp);
 static int param_get_aauint(char *buffer, const struct kernel_param *kp);
-#define param_check_aauint(name, p) __param_check(name, p, int)
+#define param_check_aauint param_check_uint
 static struct kernel_param_ops param_ops_aauint = {
 	.set = param_set_aauint,
 	.get = param_get_aauint
@@ -687,7 +687,7 @@ static struct kernel_param_ops param_ops
 
 static int param_set_aalockpolicy(const char *val, const struct kernel_param *kp);
 static int param_get_aalockpolicy(char *buffer, const struct kernel_param *kp);
-#define param_check_aalockpolicy(name, p) __param_check(name, p, int)
+#define param_check_aalockpolicy param_check_bool
 static struct kernel_param_ops param_ops_aalockpolicy = {
 	.set = param_set_aalockpolicy,
 	.get = param_get_aalockpolicy

Re: [PATCH 8/15] apparmor: fix module parameter handling

[John Johansen]

On 12/14/2011 07:11 PM, Rusty Russell wrote:
> The 'aabool' wrappers actually pass off to the 'bool' parse functions,
> so you should use the same check function.  Similarly for aauint and
> uint.
> 
yep, thanks Rusty

> (Note that 'bool' module parameters also allow 'int', which is why you
> got away with this, but that's changing very soon.)
> 
> Cc: John Johansen <john.johansen@canonical.com>
> Cc: James Morris <jmorris@namei.org>
> Cc: linux-security-module@vger.kernel.org
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Acked-by: John Johansen <john.johansen@canonical.com>

> ---
>  security/apparmor/lsm.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
> --- a/security/apparmor/lsm.c
> +++ b/security/apparmor/lsm.c
> @@ -671,7 +671,7 @@ static struct security_operations apparm
>  
>  static int param_set_aabool(const char *val, const struct kernel_param *kp);
>  static int param_get_aabool(char *buffer, const struct kernel_param *kp);
> -#define param_check_aabool(name, p) __param_check(name, p, int)
> +#define param_check_aabool param_check_bool
>  static struct kernel_param_ops param_ops_aabool = {
>  	.set = param_set_aabool,
>  	.get = param_get_aabool
> @@ -679,7 +679,7 @@ static struct kernel_param_ops param_ops
>  
>  static int param_set_aauint(const char *val, const struct kernel_param *kp);
>  static int param_get_aauint(char *buffer, const struct kernel_param *kp);
> -#define param_check_aauint(name, p) __param_check(name, p, int)
> +#define param_check_aauint param_check_uint
>  static struct kernel_param_ops param_ops_aauint = {
>  	.set = param_set_aauint,
>  	.get = param_get_aauint
> @@ -687,7 +687,7 @@ static struct kernel_param_ops param_ops
>  
>  static int param_set_aalockpolicy(const char *val, const struct kernel_param *kp);
>  static int param_get_aalockpolicy(char *buffer, const struct kernel_param *kp);
> -#define param_check_aalockpolicy(name, p) __param_check(name, p, int)
> +#define param_check_aalockpolicy param_check_bool
>  static struct kernel_param_ops param_ops_aalockpolicy = {
>  	.set = param_set_aalockpolicy,
>  	.get = param_get_aalockpolicy

Re: [PATCH 8/15] apparmor: fix module parameter handling

[James Morris]

On Thu, 15 Dec 2011, John Johansen wrote:

> On 12/14/2011 07:11 PM, Rusty Russell wrote:
> > The 'aabool' wrappers actually pass off to the 'bool' parse functions,
> > so you should use the same check function.  Similarly for aauint and
> > uint.
> > 
> yep, thanks Rusty
> 
> > (Note that 'bool' module parameters also allow 'int', which is why you
> > got away with this, but that's changing very soon.)
> > 
> > Cc: John Johansen <john.johansen@canonical.com>
> > Cc: James Morris <jmorris@namei.org>
> > Cc: linux-security-module@vger.kernel.org
> > Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> Acked-by: John Johansen <john.johansen@canonical.com>
> 

Applied to
git://selinuxproject.org/~jmorris/linux-security next

-- 
James Morris
<jmorris@namei.org>