[PATCH] telit: use CIND "rssi" indicator instead of "signal"

[PATCH] telit: use CIND "rssi" indicator instead of "signal"

[Christopher.Vogl]

[-- Attachment #1: Type: text/plain, Size: 1600 bytes --]

From: Christopher Vogl <christopher.vogl@hale.at>

"signal" indicator permanently reports 99 (not measurable).
---
 drivers/atmodem/network-registration.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/atmodem/network-registration.c b/drivers/atmodem/network-registration.c
index 2d808ad..b943241 100644
--- a/drivers/atmodem/network-registration.c
+++ b/drivers/atmodem/network-registration.c
@@ -1288,6 +1288,7 @@ static void cind_support_cb(gboolean ok, GAtResult *result, gpointer user_data)
 	struct netreg_data *nd = ofono_netreg_get_data(netreg);
 	GAtResultIter iter;
 	const char *str;
+	char *signal_identifier = "signal";
 	int index;
 	int min = 0;
 	int max = 0;
@@ -1306,8 +1307,10 @@ static void cind_support_cb(gboolean ok, GAtResult *result, gpointer user_data)
 	 * Telit encapsulates the CIND=? tokens with braces
 	 * so we need to skip them
 	 */
-	if (nd->vendor == OFONO_VENDOR_TELIT)
+	if (nd->vendor == OFONO_VENDOR_TELIT) {
 		g_at_result_iter_open_list(&iter);
+		signal_identifier = "rssi";
+	}
 
 	while (g_at_result_iter_open_list(&iter)) {
 		/* Reset invalid default value for every token */
@@ -1333,7 +1336,7 @@ static void cind_support_cb(gboolean ok, GAtResult *result, gpointer user_data)
 		if (!g_at_result_iter_close_list(&iter))
 			goto error;
 
-		if (g_str_equal("signal", str) == TRUE) {
+		if (g_str_equal(signal_identifier, str) == TRUE) {
 			nd->signal_index = index;
 			nd->signal_min = min;
 			nd->signal_max = max;
-- 
1.7.4.4



--
Scanned by MailScanner.

Re: [PATCH] telit: use CIND "rssi" indicator instead of "signal"

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

Hi Christopher,

On 12/15/2011 07:34 AM, Christopher.Vogl(a)hale.at wrote:
> From: Christopher Vogl <christopher.vogl@hale.at>
> 
> "signal" indicator permanently reports 99 (not measurable).
> ---
>  drivers/atmodem/network-registration.c |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)
> 

Patch has been applied, thanks.

Regards,
-Denis