From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: "Shen, Voice" <Voice.Shen@atmel.com>
Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, "Lin,
JM" <JM.Lin@atmel.com>, "Xu, Hong" <Hong.Xu@atmel.com>
Subject: Re: [PATCH] atmel ac97c: using software reset instead hardware reset
Date: Fri, 16 Dec 2011 08:39:55 +0000 [thread overview]
Message-ID: <4EEB03DB.4070201@atmel.com> (raw)
In-Reply-To: <4C79549CB6F772498162A641D92D532803B527CA@penmb01.corp.atmel.com>
On 12/16/2011 02:52 AM, Shen, Voice :
> Hi Nicolas,
> No one response for this.
> Would you please merge it?
Unfortunately I cannot.
You will have to make sure that the *sound* maintainer is taking your
patch into account. It can take several iterations but you must be sure
that your work is included into maintainer's git tree.
Good luck... Bye,
> -----Original Message-----
> From: Nicolas Ferre [mailto:nicolas.ferre@atmel.com]
> Sent: Thursday, December 15, 2011 21:04 voice
> To: Shen, Voice
> Cc: linux-kernel@vger.kernel.org; linux-sound@vger.kernel.org; Lin, JM;
> Xu, Hong
> Subject: Re: [PATCH] atmel ac97c: using software reset instead hardware
> reset if not available
>
> On 11/23/2011 11:05 AM, voice :
>> Using software reset instead hardware reset if not available
>
> Ping?
> Can you please tell me what is the status of this fix? Will it go
> upstream for 3.3?
>
>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>> ---
>> sound/atmel/ac97c.c | 4 ++++
>> 1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
>> index 6e5adde..73516f6 100644
>> --- a/sound/atmel/ac97c.c
>> +++ b/sound/atmel/ac97c.c
>> @@ -899,6 +899,10 @@ static void atmel_ac97c_reset(struct atmel_ac97c
> *chip)
>> /* AC97 v2.2 specifications says minimum 1 us. */
>> udelay(2);
>> gpio_set_value(chip->reset_pin, 1);
>> + } else {
>> + ac97c_writel(chip, MR, AC97C_MR_WRST | AC97C_MR_ENA);
>> + udelay(2);
>> + ac97c_writel(chip, MR, AC97C_MR_ENA);
>> }
>> }
>>
>
>
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: "Shen, Voice" <Voice.Shen@atmel.com>
Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, "Lin,
JM" <JM.Lin@atmel.com>, "Xu, Hong" <Hong.Xu@atmel.com>
Subject: Re: [PATCH] atmel ac97c: using software reset instead hardware reset if not available
Date: Fri, 16 Dec 2011 09:39:55 +0100 [thread overview]
Message-ID: <4EEB03DB.4070201@atmel.com> (raw)
In-Reply-To: <4C79549CB6F772498162A641D92D532803B527CA@penmb01.corp.atmel.com>
On 12/16/2011 02:52 AM, Shen, Voice :
> Hi Nicolas,
> No one response for this.
> Would you please merge it?
Unfortunately I cannot.
You will have to make sure that the *sound* maintainer is taking your
patch into account. It can take several iterations but you must be sure
that your work is included into maintainer's git tree.
Good luck... Bye,
> -----Original Message-----
> From: Nicolas Ferre [mailto:nicolas.ferre@atmel.com]
> Sent: Thursday, December 15, 2011 21:04 voice
> To: Shen, Voice
> Cc: linux-kernel@vger.kernel.org; linux-sound@vger.kernel.org; Lin, JM;
> Xu, Hong
> Subject: Re: [PATCH] atmel ac97c: using software reset instead hardware
> reset if not available
>
> On 11/23/2011 11:05 AM, voice :
>> Using software reset instead hardware reset if not available
>
> Ping?
> Can you please tell me what is the status of this fix? Will it go
> upstream for 3.3?
>
>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>> ---
>> sound/atmel/ac97c.c | 4 ++++
>> 1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
>> index 6e5adde..73516f6 100644
>> --- a/sound/atmel/ac97c.c
>> +++ b/sound/atmel/ac97c.c
>> @@ -899,6 +899,10 @@ static void atmel_ac97c_reset(struct atmel_ac97c
> *chip)
>> /* AC97 v2.2 specifications says minimum 1 us. */
>> udelay(2);
>> gpio_set_value(chip->reset_pin, 1);
>> + } else {
>> + ac97c_writel(chip, MR, AC97C_MR_WRST | AC97C_MR_ENA);
>> + udelay(2);
>> + ac97c_writel(chip, MR, AC97C_MR_ENA);
>> }
>> }
>>
>
>
--
Nicolas Ferre
next prev parent reply other threads:[~2011-12-16 8:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 10:05 [PATCH] atmel ac97c: using software reset instead hardware reset if not available voice
2011-11-23 10:05 ` voice
2011-11-24 10:44 ` [PATCH] atmel ac97c: using software reset instead hardware reset Nicolas Ferre
2011-11-24 10:44 ` [PATCH] atmel ac97c: using software reset instead hardware reset if not available Nicolas Ferre
2011-12-15 13:04 ` [PATCH] atmel ac97c: using software reset instead hardware reset Nicolas Ferre
2011-12-15 13:04 ` [PATCH] atmel ac97c: using software reset instead hardware reset if not available Nicolas Ferre
2011-12-16 1:52 ` Shen, Voice
2011-12-16 1:52 ` Shen, Voice
2011-12-16 8:39 ` Nicolas Ferre [this message]
2011-12-16 8:39 ` Nicolas Ferre
-- strict thread matches above, loose matches on Subject: below --
2011-12-19 2:49 FW: " Shen, Voice
2011-12-19 2:49 ` Shen, Voice
2011-12-19 2:49 ` Shen, Voice
2011-12-19 9:43 ` Takashi Iwai
2011-12-19 9:43 ` Takashi Iwai
2011-12-19 9:43 ` Takashi Iwai
2011-12-19 9:57 voice
2011-12-19 9:57 ` voice
2011-12-19 9:57 ` voice
2011-12-19 10:28 ` Takashi Iwai
2011-12-19 10:28 ` Takashi Iwai
2011-12-19 10:28 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEB03DB.4070201@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=Hong.Xu@atmel.com \
--cc=JM.Lin@atmel.com \
--cc=Voice.Shen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.