[PATCH net-next v2] igb: reset PHY after recovering from PHY power down

[PATCH net-next v2] igb: reset PHY after recovering from PHY power down

[Koki Sanagi]

According to 82576_Datasheet.pdf, PHY setting is lost after PHY power down.
So resetting PHY is needed when recovering from PHY power down to set a default
setting to PHY register.
Owing to this lack, NIC doesn't link up in some rare situation.

Signed-off-by: Koki Sanagi <sanagi.koki@jp.fujitsu.com>
---
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index 89d576c..9b923b0 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -1498,6 +1498,7 @@ void igb_power_up_link(struct igb_adapter *adapter)
 		igb_power_up_phy_copper(&adapter->hw);
 	else
 		igb_power_up_serdes_link_82575(&adapter->hw);
+	igb_reset_phy(&adapter->hw);
 }
 
 /**


------------------------------------------------------------------------------
Learn Windows Azure Live!  Tuesday, Dec 13, 2011
Microsoft is holding a special Learn Windows Azure training event for 
developers. It will provide a great way to learn Windows Azure and what it 
provides. You can attend the event by watching it streamed LIVE online.  
Learn more at http://p.sf.net/sfu/ms-windowsazure
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired

RE: [PATCH net-next v2] igb: reset PHY after recovering from PHY power down

[Wyborny, Carolyn]

>-----Original Message-----
>From: Koki Sanagi [mailto:sanagi.koki@jp.fujitsu.com]
>Sent: Sunday, December 18, 2011 5:24 PM
>To: netdev@vger.kernel.org
>Cc: davem@davemloft.net; e1000-devel@lists.sourceforge.net; Wyborny,
>Carolyn; Kirsher, Jeffrey T; Brandeburg, Jesse; Allan, Bruce W;
>Skidmore, Donald C; Rose, Gregory V; Waskiewicz Jr, Peter P; Duyck,
>Alexander H; Ronciak, John
>Subject: [PATCH net-next v2] igb: reset PHY after recovering from PHY
>power down
>
>According to 82576_Datasheet.pdf, PHY setting is lost after PHY power
>down.
>So resetting PHY is needed when recovering from PHY power down to set a
>default
>setting to PHY register.
>Owing to this lack, NIC doesn't link up in some rare situation.
>
>Signed-off-by: Koki Sanagi <sanagi.koki@jp.fujitsu.com>
>---
>diff --git a/drivers/net/ethernet/intel/igb/igb_main.c
>b/drivers/net/ethernet/intel/igb/igb_main.c
>index 89d576c..9b923b0 100644
>--- a/drivers/net/ethernet/intel/igb/igb_main.c
>+++ b/drivers/net/ethernet/intel/igb/igb_main.c
>@@ -1498,6 +1498,7 @@ void igb_power_up_link(struct igb_adapter
>*adapter)
> 		igb_power_up_phy_copper(&adapter->hw);
> 	else
> 		igb_power_up_serdes_link_82575(&adapter->hw);
>+	igb_reset_phy(&adapter->hw);
> }
>
> /**

ACK


Carolyn Wyborny
Linux Development
LAN Access Division
Intel Corporation

Re: [PATCH net-next v2] igb: reset PHY after recovering from PHY power down

[Jeff Kirsher]

[-- Attachment #1: Type: text/plain, Size: 436 bytes --]

On Sun, 2011-12-18 at 17:24 -0800, Koki Sanagi wrote:
> According to 82576_Datasheet.pdf, PHY setting is lost after PHY power
> down.
> So resetting PHY is needed when recovering from PHY power down to set
> a default
> setting to PHY register.
> Owing to this lack, NIC doesn't link up in some rare situation.
> 
> Signed-off-by: Koki Sanagi <sanagi.koki@jp.fujitsu.com> 

I have added this patch to my queue.  Thanks Koki!

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]