From: Hong Xu <hong.xu@atmel.com>
To: dedekind1@gmail.com
Cc: linux-mtd@lists.infradead.org, David.Woodhouse@intel.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] MTD: atmel_nand: Update Kconfig to support PMECC
Date: Mon, 19 Dec 2011 09:58:28 +0800 [thread overview]
Message-ID: <4EEE9A44.6080401@atmel.com> (raw)
In-Reply-To: <1324136016.4240.48.camel@sauron.fi.intel.com>
On 12/17/2011 11:33 PM, Artem Bityutskiy wrote:
> On Tue, 2011-12-13 at 09:58 +0800, Hong Xu wrote:
>> PMECC is not compatible with the old HW ECC engine. It currently needs
>> around 700 lines of C code to make it work. If we do not have a way to
>> exclude the PMECC related code at compiling time, my quick testing shows
>> that the driver code size will be doubled if some old SoCs do not
>> support it. This sounds not good. What's your opinion?
>
> Well, depends on its size. Say, if it is about 8KiB - then doubling it
> is probably not a big deal.
>
Hmm.., not that big, less than 8KB. OK, I'll send out another patch
removing the stuff modified in Kconfig.
Thanks!
BR,
Eric
WARNING: multiple messages have this Message-ID (diff)
From: hong.xu@atmel.com (Hong Xu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] MTD: atmel_nand: Update Kconfig to support PMECC
Date: Mon, 19 Dec 2011 09:58:28 +0800 [thread overview]
Message-ID: <4EEE9A44.6080401@atmel.com> (raw)
In-Reply-To: <1324136016.4240.48.camel@sauron.fi.intel.com>
On 12/17/2011 11:33 PM, Artem Bityutskiy wrote:
> On Tue, 2011-12-13 at 09:58 +0800, Hong Xu wrote:
>> PMECC is not compatible with the old HW ECC engine. It currently needs
>> around 700 lines of C code to make it work. If we do not have a way to
>> exclude the PMECC related code at compiling time, my quick testing shows
>> that the driver code size will be doubled if some old SoCs do not
>> support it. This sounds not good. What's your opinion?
>
> Well, depends on its size. Say, if it is about 8KiB - then doubling it
> is probably not a big deal.
>
Hmm.., not that big, less than 8KB. OK, I'll send out another patch
removing the stuff modified in Kconfig.
Thanks!
BR,
Eric
next prev parent reply other threads:[~2011-12-19 1:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 6:53 [PATCH 1/2] MTD: atmel_nand: Update Kconfig to support PMECC Hong Xu
2011-12-08 6:53 ` Hong Xu
2011-12-08 6:53 ` [PATCH 2/2] MTD: atmel_nand: Update driver code to support Programmable HW ECC controller Hong Xu
2011-12-08 6:53 ` Hong Xu
2011-12-12 20:58 ` [PATCH 1/2] MTD: atmel_nand: Update Kconfig to support PMECC Artem Bityutskiy
2011-12-12 20:58 ` Artem Bityutskiy
2011-12-13 1:14 ` Hong Xu
2011-12-13 1:14 ` Hong Xu
2011-12-13 1:58 ` Hong Xu
2011-12-13 1:58 ` Hong Xu
2011-12-17 15:33 ` Artem Bityutskiy
2011-12-17 15:33 ` Artem Bityutskiy
2011-12-19 1:58 ` Hong Xu [this message]
2011-12-19 1:58 ` Hong Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEE9A44.6080401@atmel.com \
--to=hong.xu@atmel.com \
--cc=David.Woodhouse@intel.com \
--cc=dedekind1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.