From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
Antonino Daplas <adaplas@gmail.com>,
linux-fbdev@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>
Subject: Re: [PATCH 3/15] i810: fix module_param bool abuse.
Date: Mon, 19 Dec 2011 23:16:04 +0000 [thread overview]
Message-ID: <4EEFC5B4.9000704@gmx.de> (raw)
In-Reply-To: <874nx2tu1v.fsf@rustcorp.com.au>
On 12/15/2011 03:03 AM, Rusty Russell wrote:
> The driver says "module_param(ddc3, bool, 0);". But it's not a used
> as a bool, it's used as a count.
>
> Make it a bool.
>
> Cc: Antonino Daplas <adaplas@gmail.com>
> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
> Cc: linux-fbdev@vger.kernel.org
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Applied.
Thanks,
Florian Tobias Schandinat
> ---
> drivers/video/i810/i810_main.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/video/i810/i810_main.c b/drivers/video/i810/i810_main.c
> --- a/drivers/video/i810/i810_main.c
> +++ b/drivers/video/i810/i810_main.c
> @@ -147,7 +147,7 @@ static int vyres __devinitdata;
> static int sync __devinitdata;
> static int extvga __devinitdata;
> static int dcolor __devinitdata;
> -static int ddc3 __devinitdata = 2;
> +static bool ddc3 __devinitdata;
>
> /*------------------------------------------------------------*/
>
> @@ -1776,7 +1776,7 @@ static void __devinit i810_init_defaults
> if (sync)
> par->dev_flags |= ALWAYS_SYNC;
>
> - par->ddc_num = ddc3;
> + par->ddc_num = (ddc3 ? 3 : 2);
>
> if (bpp < 8)
> bpp = 8;
> @@ -1999,7 +1999,7 @@ static int __devinit i810fb_setup(char *
> else if (!strncmp(this_opt, "dcolor", 6))
> dcolor = 1;
> else if (!strncmp(this_opt, "ddc3", 4))
> - ddc3 = 3;
> + ddc3 = true;
> else
> mode_option = this_opt;
> }
>
next prev parent reply other threads:[~2011-12-19 23:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 3:03 [PATCH 3/15] i810: fix module_param bool abuse Rusty Russell
2011-12-15 3:15 ` Rusty Russell
2011-12-19 23:16 ` Florian Tobias Schandinat [this message]
2012-01-12 22:57 ` Rusty Russell
2012-01-12 23:09 ` Rusty Russell
2012-01-12 23:36 ` Florian Tobias Schandinat
2012-01-12 23:36 ` Florian Tobias Schandinat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEFC5B4.9000704@gmx.de \
--to=florianschandinat@gmx.de \
--cc=adaplas@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.