From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
Antonino Daplas <adaplas@gmail.com>,
linux-fbdev@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>
Subject: Re: [PATCH 3/15] i810: fix module_param bool abuse.
Date: Thu, 12 Jan 2012 23:36:05 +0000 [thread overview]
Message-ID: <4F0F6E65.7020009@gmx.de> (raw)
In-Reply-To: <87sjjk34wx.fsf@rustcorp.com.au>
Hi Rusty,
On 01/12/2012 10:57 PM, Rusty Russell wrote:
> On Mon, 19 Dec 2011 23:16:04 +0000, Florian Tobias Schandinat <FlorianSchandinat@gmx.de> wrote:
>> On 12/15/2011 03:03 AM, Rusty Russell wrote:
>>> The driver says "module_param(ddc3, bool, 0);". But it's not a used
>>> as a bool, it's used as a count.
>>>
>>> Make it a bool.
>>>
>>> Cc: Antonino Daplas <adaplas@gmail.com>
>>> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
>>> Cc: linux-fbdev@vger.kernel.org
>>> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>>
>> Applied.
>
> Hmm, I don't see this in Linus' tree yet, and it's a context-clash
> pre-requisite for part of the general driver bool conversion. I want to
> push today since I have linux.conf.au next week, so I've split the i810
> conversion into a separate patch, below.
Sorry for the delay, but with an OMAP pull and a revert this merge window is not
as quiet as I wished.
> It's been over a week in linux-next, can you push this please?
Sure, I've taken it and also fixed the subject.
Best regards,
Florian Tobias Schandinat
>
> From: Rusty Russell <rusty@rustcorp.com.au>
> Subject: module_param: make bool parameters really bool (drivers/vidio/i810)
>
> module_param(bool) used to counter-intuitively take an int. In
> fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
> trick.
>
> It's time to remove the int/unsigned int option. For this version
> it'll simply give a warning, but it'll break next kernel version.
>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>
> diff --git a/drivers/video/i810/i810_main.c b/drivers/video/i810/i810_main.c
> --- a/drivers/video/i810/i810_main.c
> +++ b/drivers/video/i810/i810_main.c
> @@ -135,8 +135,8 @@ static struct pci_driver i810fb_driver > static char *mode_option __devinitdata = NULL;
> static int vram __devinitdata = 4;
> static int bpp __devinitdata = 8;
> -static int mtrr __devinitdata;
> -static int accel __devinitdata;
> +static bool mtrr __devinitdata;
> +static bool accel __devinitdata;
> static int hsync1 __devinitdata;
> static int hsync2 __devinitdata;
> static int vsync1 __devinitdata;
> @@ -144,9 +144,9 @@ static int vsync2 __devinitdata;
> static int xres __devinitdata;
> static int yres;
> static int vyres __devinitdata;
> -static int sync __devinitdata;
> -static int extvga __devinitdata;
> -static int dcolor __devinitdata;
> +static bool sync __devinitdata;
> +static bool extvga __devinitdata;
> +static bool dcolor __devinitdata;
> static bool ddc3 __devinitdata;
>
> /*------------------------------------------------------------*/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
Antonino Daplas <adaplas@gmail.com>,
linux-fbdev@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>
Subject: Re: [PATCH 3/15] i810: fix module_param bool abuse.
Date: Thu, 12 Jan 2012 23:36:05 +0000 [thread overview]
Message-ID: <4F0F6E65.7020009@gmx.de> (raw)
In-Reply-To: <87sjjk34wx.fsf@rustcorp.com.au>
Hi Rusty,
On 01/12/2012 10:57 PM, Rusty Russell wrote:
> On Mon, 19 Dec 2011 23:16:04 +0000, Florian Tobias Schandinat <FlorianSchandinat@gmx.de> wrote:
>> On 12/15/2011 03:03 AM, Rusty Russell wrote:
>>> The driver says "module_param(ddc3, bool, 0);". But it's not a used
>>> as a bool, it's used as a count.
>>>
>>> Make it a bool.
>>>
>>> Cc: Antonino Daplas <adaplas@gmail.com>
>>> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
>>> Cc: linux-fbdev@vger.kernel.org
>>> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>>
>> Applied.
>
> Hmm, I don't see this in Linus' tree yet, and it's a context-clash
> pre-requisite for part of the general driver bool conversion. I want to
> push today since I have linux.conf.au next week, so I've split the i810
> conversion into a separate patch, below.
Sorry for the delay, but with an OMAP pull and a revert this merge window is not
as quiet as I wished.
> It's been over a week in linux-next, can you push this please?
Sure, I've taken it and also fixed the subject.
Best regards,
Florian Tobias Schandinat
>
> From: Rusty Russell <rusty@rustcorp.com.au>
> Subject: module_param: make bool parameters really bool (drivers/vidio/i810)
>
> module_param(bool) used to counter-intuitively take an int. In
> fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
> trick.
>
> It's time to remove the int/unsigned int option. For this version
> it'll simply give a warning, but it'll break next kernel version.
>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>
> diff --git a/drivers/video/i810/i810_main.c b/drivers/video/i810/i810_main.c
> --- a/drivers/video/i810/i810_main.c
> +++ b/drivers/video/i810/i810_main.c
> @@ -135,8 +135,8 @@ static struct pci_driver i810fb_driver =
> static char *mode_option __devinitdata = NULL;
> static int vram __devinitdata = 4;
> static int bpp __devinitdata = 8;
> -static int mtrr __devinitdata;
> -static int accel __devinitdata;
> +static bool mtrr __devinitdata;
> +static bool accel __devinitdata;
> static int hsync1 __devinitdata;
> static int hsync2 __devinitdata;
> static int vsync1 __devinitdata;
> @@ -144,9 +144,9 @@ static int vsync2 __devinitdata;
> static int xres __devinitdata;
> static int yres;
> static int vyres __devinitdata;
> -static int sync __devinitdata;
> -static int extvga __devinitdata;
> -static int dcolor __devinitdata;
> +static bool sync __devinitdata;
> +static bool extvga __devinitdata;
> +static bool dcolor __devinitdata;
> static bool ddc3 __devinitdata;
>
> /*------------------------------------------------------------*/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-01-12 23:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 3:03 [PATCH 3/15] i810: fix module_param bool abuse Rusty Russell
2011-12-15 3:15 ` Rusty Russell
2011-12-19 23:16 ` Florian Tobias Schandinat
2012-01-12 22:57 ` Rusty Russell
2012-01-12 23:09 ` Rusty Russell
2012-01-12 23:36 ` Florian Tobias Schandinat [this message]
2012-01-12 23:36 ` Florian Tobias Schandinat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0F6E65.7020009@gmx.de \
--to=florianschandinat@gmx.de \
--cc=adaplas@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.