From: Glauber Costa <glommer@parallels.com>
To: Stanislav Kinsbursky <skinsbursky@parallels.com>
Cc: <Trond.Myklebust@netapp.com>, <linux-nfs@vger.kernel.org>,
<xemul@parallels.com>, <neilb@suse.de>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <bfields@fieldses.org>,
<davem@davemloft.net>, <devel@openvz.org>
Subject: Re: [Devel] [PATCH] SUNRPC: search for service transports in network namespace context
Date: Tue, 20 Dec 2011 14:25:53 +0400 [thread overview]
Message-ID: <4EF062B1.3030401@parallels.com> (raw)
In-Reply-To: <20111220101419.5673.21926.stgit@localhost6.localdomain6>
On 12/20/2011 03:14 PM, Stanislav Kinsbursky wrote:
> Service transports are parametrized by network namespace. And thus lookup of
> transport instance have to take network namespace into account.
>
> Signed-off-by: Stanislav Kinsbursky<skinsbursky@parallels.com>
>
> ---
> fs/lockd/svc.c | 2 +-
> fs/nfsd/nfsctl.c | 4 ++--
> include/linux/sunrpc/svc_xprt.h | 3 ++-
> net/sunrpc/svc_xprt.c | 6 +++++-
> 4 files changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
> index c061b9a..ff379ff 100644
> --- a/fs/lockd/svc.c
> +++ b/fs/lockd/svc.c
> @@ -193,7 +193,7 @@ static int create_lockd_listener(struct svc_serv *serv, const char *name,
> {
> struct svc_xprt *xprt;
>
> - xprt = svc_find_xprt(serv, name, family, 0);
> + xprt = svc_find_xprt(serv, name,&init_net, family, 0);
> if (xprt == NULL)
> return svc_create_xprt(serv, name,&init_net, family, port,
> SVC_SOCK_DEFAULTS);
I might be missing something, but isn't it (at least part of it) already
merged in commit fc5d00b04a3a58cac8620403dfe9f43f72578ec1 ?
WARNING: multiple messages have this Message-ID (diff)
From: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
To: Stanislav Kinsbursky
<skinsbursky-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
Cc: <Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>,
<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<xemul-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>,
<neilb-l3A5Bk7waGM@public.gmane.org>,
<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>,
<davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
<devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
Subject: Re: [Devel] [PATCH] SUNRPC: search for service transports in network namespace context
Date: Tue, 20 Dec 2011 14:25:53 +0400 [thread overview]
Message-ID: <4EF062B1.3030401@parallels.com> (raw)
In-Reply-To: <20111220101419.5673.21926.stgit-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
On 12/20/2011 03:14 PM, Stanislav Kinsbursky wrote:
> Service transports are parametrized by network namespace. And thus lookup of
> transport instance have to take network namespace into account.
>
> Signed-off-by: Stanislav Kinsbursky<skinsbursky-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
>
> ---
> fs/lockd/svc.c | 2 +-
> fs/nfsd/nfsctl.c | 4 ++--
> include/linux/sunrpc/svc_xprt.h | 3 ++-
> net/sunrpc/svc_xprt.c | 6 +++++-
> 4 files changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
> index c061b9a..ff379ff 100644
> --- a/fs/lockd/svc.c
> +++ b/fs/lockd/svc.c
> @@ -193,7 +193,7 @@ static int create_lockd_listener(struct svc_serv *serv, const char *name,
> {
> struct svc_xprt *xprt;
>
> - xprt = svc_find_xprt(serv, name, family, 0);
> + xprt = svc_find_xprt(serv, name,&init_net, family, 0);
> if (xprt == NULL)
> return svc_create_xprt(serv, name,&init_net, family, port,
> SVC_SOCK_DEFAULTS);
I might be missing something, but isn't it (at least part of it) already
merged in commit fc5d00b04a3a58cac8620403dfe9f43f72578ec1 ?
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-12-20 10:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 11:14 [PATCH] SUNRPC: search for service transports in network namespace context Stanislav Kinsbursky
2011-12-20 10:25 ` Glauber Costa [this message]
2011-12-20 10:25 ` [Devel] " Glauber Costa
2011-12-20 10:31 ` Stanislav Kinsbursky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF062B1.3030401@parallels.com \
--to=glommer@parallels.com \
--cc=Trond.Myklebust@netapp.com \
--cc=bfields@fieldses.org \
--cc=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=skinsbursky@parallels.com \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.