All of lore.kernel.org
 help / color / mirror / Atom feed
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] davinci: DA850 EVM: OHCI platform code
Date: Tue, 20 Dec 2011 15:07:16 +0400	[thread overview]
Message-ID: <4EF06C64.8000708@mvista.com> (raw)
In-Reply-To: <1324363005-11320-1-git-send-email-prakash.pm@ti.com>

Hello.

On 20.12.2011 10:36, Manjunathappa, Prakash wrote:

> From: Ajay Kumar Gupta <ajay.gupta@ti.com>

    It's a good practice to CC the original author of the patch -- which I'm 
doing now...

> On this board the OHCI port's power control and over-current signals from
> TPS2065 power switch are connected via GPIO1[15] and GPIO2[1] respectively,

    Ajay, your description seems to be copied unchganged from the analogous 
DA830 EVM patch, and thus doesn't match your patch: GPIO2[4] and GPIO6[13] are 
used apparently. Be more attentive to detail next time please.

> so we can implement the DA8xx OHCI glue layer's hooks for overriding the
> root hub port's power and over-current status bits.

> We also have to properly set up the clocking mode in the CFGCHIP2 register,
> so that internal 24 MHz reference clock is fed to the USB 2.0 (MUSB) PHY and
> its output is used to clock the USB 1.1 (OHCI) PHY...

> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
> ---
>   arch/arm/mach-davinci/board-da850-evm.c |  126 +++++++++++++++++++++++++++++++
>   1 files changed, 126 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-davinci/board-da850-evm.c
> index 6659a90..df74ba5 100644
> --- a/arch/arm/mach-davinci/board-da850-evm.c
> +++ b/arch/arm/mach-davinci/board-da850-evm.c
[...]
> @@ -734,6 +736,127 @@ static struct davinci_i2c_platform_data da850_evm_i2c_0_pdata = {
[...]
> +static int da850_evm_usb_ocic_notify(da8xx_ocic_handler_t handler)
> +{
> +	int irq		= gpio_to_irq(ON_BD_USB_OVC);
> +	int error	= 0;
> +
> +	if (handler != NULL) {
> +		da850_evm_usb_ocic_handler = handler;
> +
> +		error = request_irq(irq, da850_evm_usb_ocic_irq, IRQF_DISABLED |

    IRQF_DISABLED is a nop now -- just remove it.

WBR, Sergei

WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: "Manjunathappa, Prakash" <prakash.pm@ti.com>, ajay.gupta@ti.com
Cc: davinci-linux-open-source@linux.davincidsp.com,
	linux@arm.linux.org.uk, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] davinci: DA850 EVM: OHCI platform code
Date: Tue, 20 Dec 2011 15:07:16 +0400	[thread overview]
Message-ID: <4EF06C64.8000708@mvista.com> (raw)
In-Reply-To: <1324363005-11320-1-git-send-email-prakash.pm@ti.com>

Hello.

On 20.12.2011 10:36, Manjunathappa, Prakash wrote:

> From: Ajay Kumar Gupta <ajay.gupta@ti.com>

    It's a good practice to CC the original author of the patch -- which I'm 
doing now...

> On this board the OHCI port's power control and over-current signals from
> TPS2065 power switch are connected via GPIO1[15] and GPIO2[1] respectively,

    Ajay, your description seems to be copied unchganged from the analogous 
DA830 EVM patch, and thus doesn't match your patch: GPIO2[4] and GPIO6[13] are 
used apparently. Be more attentive to detail next time please.

> so we can implement the DA8xx OHCI glue layer's hooks for overriding the
> root hub port's power and over-current status bits.

> We also have to properly set up the clocking mode in the CFGCHIP2 register,
> so that internal 24 MHz reference clock is fed to the USB 2.0 (MUSB) PHY and
> its output is used to clock the USB 1.1 (OHCI) PHY...

> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
> ---
>   arch/arm/mach-davinci/board-da850-evm.c |  126 +++++++++++++++++++++++++++++++
>   1 files changed, 126 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-davinci/board-da850-evm.c
> index 6659a90..df74ba5 100644
> --- a/arch/arm/mach-davinci/board-da850-evm.c
> +++ b/arch/arm/mach-davinci/board-da850-evm.c
[...]
> @@ -734,6 +736,127 @@ static struct davinci_i2c_platform_data da850_evm_i2c_0_pdata = {
[...]
> +static int da850_evm_usb_ocic_notify(da8xx_ocic_handler_t handler)
> +{
> +	int irq		= gpio_to_irq(ON_BD_USB_OVC);
> +	int error	= 0;
> +
> +	if (handler != NULL) {
> +		da850_evm_usb_ocic_handler = handler;
> +
> +		error = request_irq(irq, da850_evm_usb_ocic_irq, IRQF_DISABLED |

    IRQF_DISABLED is a nop now -- just remove it.

WBR, Sergei

  reply	other threads:[~2011-12-20 11:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-20  6:36 [PATCH] davinci: DA850 EVM: OHCI platform code Manjunathappa, Prakash
2011-12-20  6:36 ` Manjunathappa, Prakash
2011-12-20 11:07 ` Sergei Shtylyov [this message]
2011-12-20 11:07   ` Sergei Shtylyov
2011-12-20 13:51   ` Gupta, Ajay Kumar
2011-12-20 13:51     ` Gupta, Ajay Kumar
2011-12-21  5:52   ` Manjunathappa, Prakash
2011-12-21  5:52     ` Manjunathappa, Prakash
2011-12-20 11:17 ` Sergei Shtylyov
2011-12-20 11:17   ` Sergei Shtylyov
2011-12-21  5:56   ` Manjunathappa, Prakash
2011-12-21  5:56     ` Manjunathappa, Prakash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EF06C64.8000708@mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.