From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] net: macb: fix build break with !CONFIG_OF
Date: Wed, 21 Dec 2011 22:34:55 +0100 [thread overview]
Message-ID: <4EF250FF.7090302@atmel.com> (raw)
In-Reply-To: <1324416029-28198-1-git-send-email-olof@lixom.net>
On 12/20/2011 10:20 PM, Olof Johansson :
> This fixes the build of the macb driver that was broken by the DT changes:
>
> drivers/net/ethernet/cadence/macb.c:1503: error: implicit declaration of function 'of_match_ptr'
> drivers/net/ethernet/cadence/macb.c:1503: error: 'macb_dt_ids' undeclared here (not in a function)
> drivers/net/ethernet/cadence/macb.c:1503: error: initializer element is not constant
> drivers/net/ethernet/cadence/macb.c:1503: error: (near initialization for 'macb_driver.driver.of_match_table')
>
> Signed-off-by: Olof Johansson <olof@lixom.net>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Olof, thanks for this patch.
Best regards,
> ---
>
> Nicolas, care to ack this so I can apply it on top of the macb DT branch in arm-soc?
>
> drivers/net/ethernet/cadence/macb.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index baf1a0d..f3d5c65 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -23,6 +23,7 @@
> #include <linux/platform_data/macb.h>
> #include <linux/platform_device.h>
> #include <linux/phy.h>
> +#include <linux/of.h>
> #include <linux/of_device.h>
> #include <linux/of_net.h>
>
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Olof Johansson <olof@lixom.net>
Cc: netdev@vger.kernel.org,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
Jamie Iles <jamie@jamieiles.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] net: macb: fix build break with !CONFIG_OF
Date: Wed, 21 Dec 2011 22:34:55 +0100 [thread overview]
Message-ID: <4EF250FF.7090302@atmel.com> (raw)
In-Reply-To: <1324416029-28198-1-git-send-email-olof@lixom.net>
On 12/20/2011 10:20 PM, Olof Johansson :
> This fixes the build of the macb driver that was broken by the DT changes:
>
> drivers/net/ethernet/cadence/macb.c:1503: error: implicit declaration of function 'of_match_ptr'
> drivers/net/ethernet/cadence/macb.c:1503: error: 'macb_dt_ids' undeclared here (not in a function)
> drivers/net/ethernet/cadence/macb.c:1503: error: initializer element is not constant
> drivers/net/ethernet/cadence/macb.c:1503: error: (near initialization for 'macb_driver.driver.of_match_table')
>
> Signed-off-by: Olof Johansson <olof@lixom.net>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Olof, thanks for this patch.
Best regards,
> ---
>
> Nicolas, care to ack this so I can apply it on top of the macb DT branch in arm-soc?
>
> drivers/net/ethernet/cadence/macb.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index baf1a0d..f3d5c65 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -23,6 +23,7 @@
> #include <linux/platform_data/macb.h>
> #include <linux/platform_device.h>
> #include <linux/phy.h>
> +#include <linux/of.h>
> #include <linux/of_device.h>
> #include <linux/of_net.h>
>
--
Nicolas Ferre
next prev parent reply other threads:[~2011-12-21 21:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 21:20 [PATCH] net: macb: fix build break with !CONFIG_OF Olof Johansson
2011-12-20 21:20 ` Olof Johansson
2011-12-21 6:04 ` David Miller
2011-12-21 6:04 ` David Miller
2011-12-21 21:34 ` Nicolas Ferre [this message]
2011-12-21 21:34 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF250FF.7090302@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.