Re: crash after SimManager.ResetPin()

Re: crash after SimManager.ResetPin()

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

Hi Jussi,

On 12/23/2011 12:48 PM, Kukkonen, Jussi wrote:
> Hi all,
> 
> I consistently get a crash when calling SimManager.ResetPin ("puk",
> puk, new_pin). Before this I've called ChangePin()  with wrong pin
> three times.to get "PinRequired=puk" property change.
> 
> This is a huawei E1550 USB modem.
> 

Can you please try the following patch?

Regards,
-Denis

[-- Attachment #2: 0001-sim-Fix-not-creating-simfs-context-in-some-cases.patch --]
[-- Type: text/plain, Size: 1104 bytes --]

>From 764ab4017dec61006ee7936d41e4090d58110218 Mon Sep 17 00:00:00 2001
From: Denis Kenzior <denkenz@gmail.com>
Date: Fri, 23 Dec 2011 01:27:19 -0600
Subject: [PATCH] sim: Fix not creating simfs context in some cases

---
 src/sim.c |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/sim.c b/src/sim.c
index dae824d..4412db8 100644
--- a/src/sim.c
+++ b/src/sim.c
@@ -1732,6 +1732,8 @@ static void sim_efphase_read_cb(int ok, int length, int record,
 
 static void sim_initialize_after_pin(struct ofono_sim *sim)
 {
+	sim->context = ofono_sim_context_create(sim);
+
 	ofono_sim_read(sim->context, SIM_EFPHASE_FILEID,
 			OFONO_SIM_FILE_STRUCTURE_TRANSPARENT,
 			sim_efphase_read_cb, sim);
@@ -1933,12 +1935,8 @@ skip_efpl:
 						&sim->language_prefs);
 
 	/* Proceed with sim initialization if we're not merely updating */
-	if (!sim->language_prefs_update) {
-		if (sim->context == NULL)
-			sim->context = ofono_sim_context_create(sim);
-
+	if (!sim->language_prefs_update)
 		__ofono_sim_recheck_pin(sim);
-	}
 
 	sim->language_prefs_update = FALSE;
 }
-- 
1.7.3.4

crash after SimManager.ResetPin()

[Kukkonen, Jussi]

[-- Attachment #1: Type: text/plain, Size: 5577 bytes --]

Hi all,

I consistently get a crash when calling SimManager.ResetPin ("puk",
puk, new_pin). Before this I've called ChangePin()  with wrong pin
three times.to get "PinRequired=puk" property change.

This is a huawei E1550 USB modem.

log:

ofonod[31607]: drivers/atmodem/sms.c:at_csca_query_cb() csca_query_cb:
358508771010, 145
ofonod[31607]: drivers/atmodem/sim.c:at_cpin_cb() crsm_pin_cb: READY
ofonod[31607]: drivers/atmodem/sim.c:at_pin_retries_query()
ofonod[31607]: drivers/atmodem/sim.c:huawei_cpin_cb() retry counter id=9, val=10
ofonod[31607]: drivers/atmodem/sim.c:huawei_cpin_cb() retry counter id=1, val=2
ofonod[31607]: drivers/atmodem/sim.c:huawei_cpin_cb() retry counter
id=11, val=10
ofonod[31607]: drivers/atmodem/sim.c:huawei_cpin_cb() retry counter id=4, val=3
ofonod[31607]: drivers/atmodem/sim.c:at_crsm_info_cb() crsm_info_cb: 90, 00, 30
ofonod[31607]: drivers/atmodem/sim.c:at_crsm_read_cb() crsm_read_cb: 90, 00, 4
ofonod[31607]: src/simfs.c:sim_fs_op_read_block_cb() bufoff: 0,
dataoff: 0, tocopy: 4
ofonod[31607]: drivers/atmodem/sim.c:at_crsm_info_cb() crsm_info_cb: 90, 00, 30
ofonod[31607]: drivers/atmodem/sim.c:at_crsm_read_cb() crsm_read_cb: 90, 00, 8
ofonod[31607]: src/simfs.c:sim_fs_op_read_block_cb() bufoff: 0,
dataoff: 0, tocopy: 8
ofonod[31607]: drivers/atmodem/sim.c:at_crsm_info_cb() crsm_info_cb: 90, 00, 30
ofonod[31607]: drivers/atmodem/sim.c:at_cpin_cb() crsm_pin_cb: READY
ofonod[31607]: drivers/atmodem/sim.c:at_pin_retries_query()
ofonod[31607]: drivers/atmodem/sim.c:at_crsm_read_cb() crsm_read_cb: 90, 00, 1
ofonod[31607]: src/simfs.c:sim_fs_op_read_block_cb() bufoff: 0,
dataoff: 0, tocopy: 1
ofonod[31607]: drivers/atmodem/sim.c:huawei_cpin_cb() retry counter id=9, val=10
ofonod[31607]: drivers/atmodem/sim.c:huawei_cpin_cb() retry counter id=1, val=1
ofonod[31607]: drivers/atmodem/sim.c:huawei_cpin_cb() retry counter
id=11, val=10
ofonod[31607]: drivers/atmodem/sim.c:huawei_cpin_cb() retry counter id=4, val=3
ofonod[31607]: drivers/atmodem/sim.c:at_cimi_cb() cimi_cb: 244052260583237
ofonod[31607]: src/simfs.c:sim_fs_op_read_block() bufoff: 0, seekoff:
39, toread: 4
ofonod[31607]: src/simfs.c:sim_fs_op_read_block() bufoff: 0, seekoff:
39, toread: 8
ofonod[31607]: drivers/atmodem/sim.c:at_crsm_info_cb() crsm_info_cb: 90, 00, 30
ofonod[31607]: drivers/atmodem/sim.c:at_crsm_read_cb() crsm_read_cb: 90, 00, 1
ofonod[31607]: src/simfs.c:sim_fs_op_read_block_cb() bufoff: 0,
dataoff: 0, tocopy: 1
ofonod[31607]: drivers/atmodem/sim.c:at_cimi_cb() cimi_cb: 244052260583237
ofonod[31607]: drivers/atmodem/sim.c:at_cpin_cb() crsm_pin_cb: SIM PUK
ofonod[31607]: src/modem.c:modem_change_state() old state: 2, new state: 1
ofonod[31607]: src/modem.c:flush_atoms()
ofonod[31607]: Example Network Time Remove for modem: 0x87e29b0
ofonod[31607]: Example History Remove for modem: 0x87e29b0
ofonod[31607]: src/gprs.c:gprs_context_unregister() 0x87e9ea0, 0x87e9d50
ofonod[31607]: src/gprs.c:gprs_context_remove() atom: 0x87e9ec0
ofonod[31607]: drivers/atmodem/gprs-context.c:at_gprs_context_remove()
ofonod[31607]: Unregistered handle for channel 1: 0x10006
ofonod[31607]: src/gprs.c:gprs_unregister() 0x87e9d50
ofonod[31607]: src/gprs.c:gprs_remove() atom: 0x87e9db8
ofonod[31607]: plugins/push-notification.c:push_notification_cleanup() 0x87e5148
ofonod[31607]: plugins/smart-messaging.c:smart_messaging_cleanup() 0x87eb0d0
ofonod[31607]: src/sms.c:sms_remove() atom: 0x87e9ca8
ofonod[31607]: src/radio-settings.c:radio_settings_remove() atom: 0x87e7148
ofonod[31607]: src/phonebook.c:phonebook_remove() atom: 0x87e7058
ofonod[31607]: src/audio-settings.c:audio_settings_remove() atom: 0x87eaf10
ofonod[31607]: src/voicecall.c:voicecall_remove() atom: 0x87ea778
ofonod[31607]: drivers/atmodem/sim.c:at_pin_retries_query()
ofonod[31607]: drivers/atmodem/sim.c:huawei_cpin_cb() retry counter id=9, val=10
ofonod[31607]: drivers/atmodem/sim.c:huawei_cpin_cb() retry counter id=1, val=0
ofonod[31607]: drivers/atmodem/sim.c:huawei_cpin_cb() retry counter
id=11, val=10
ofonod[31607]: drivers/atmodem/sim.c:huawei_cpin_cb() retry counter id=4, val=3
ofonod[31607]: drivers/atmodem/sim.c:at_cpin_cb() crsm_pin_cb: READY
ofonod[31607]: drivers/atmodem/sim.c:at_pin_retries_query()
ofonod[31607]: Aborting (signal 11) [src/ofonod]
ofonod[31607]: ++++++++ backtrace ++++++++
ofonod[31607]: #0  0xb7823400 in
ofonod[31607]: #1  0x811306c in sim_fs_read() at src/simfs.c:895
ofonod[31607]: #2  0x80f101f in ofono_sim_read() at src/sim.c:2096
ofonod[31607]: #3  0x80f1600 in sim_initialize_after_pin() at src/sim.c:1739
ofonod[31607]: #4  0x80f1725 in sim_pin_query_cb() at src/sim.c:2427
ofonod[31607]: #5  0x8091657 in at_cpin_cb() at drivers/atmodem/sim.c:864
ofonod[31607]: #6  0x8079c15 in at_chat_finish_command() at
gatchat/gatchat.c:461
ofonod[31607]: #7  0x807aa3a in at_chat_handle_command_response() at
gatchat/gatchat.c:524
ofonod[31607]: #8  0x807ca46 in received_data() at gatchat/gatio.c:125
ofonod[31607]: #9  0xb77609ce in /lib/i386-linux-gnu/libglib-2.0.so.0
ofonod[31607]: #10 0xb771aa3f in /lib/i386-linux-gnu/libglib-2.0.so.0
ofonod[31607]: #11 0xb771b170 in /lib/i386-linux-gnu/libglib-2.0.so.0
ofonod[31607]: #12 0xb771b77b in /lib/i386-linux-gnu/libglib-2.0.so.0
ofonod[31607]: #13 0x8054599 in main() at src/main.c:262
ofonod[31607]: #14 0xb751ae46 in /lib/i386-linux-gnu/i686/cmov/libc.so.6
ofonod[31607]: +++++++++++++++++++++++++++



I'd rather bring you nicer presents but ... merry christmas anyway,
  Jussi

Re: crash after SimManager.ResetPin()

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 722 bytes --]

Hi Jussi,

On 12/27/2011 05:12 AM, Kukkonen, Jussi wrote:
> On Fri, Dec 23, 2011 at 9:28 AM, Denis Kenzior <denkenz@gmail.com> wrote:
>> Hi Jussi,
>>
>> On 12/23/2011 12:48 PM, Kukkonen, Jussi wrote:
>>> Hi all,
>>>
>>> I consistently get a crash when calling SimManager.ResetPin ("puk",
>>> puk, new_pin). Before this I've called ChangePin()  with wrong pin
>>> three times.to get "PinRequired=puk" property change.
>>>
>>> This is a huawei E1550 USB modem.
>>>
>>
>> Can you please try the following patch?
>>
>> Regards,
>> -Denis
> 
> That works nicely, I cannot reproduce the crash with your patch. thanks.
> 
> Jussi

Thanks for testing, patch has been pushed upstream.

Regards,
-Denis

Re: crash after SimManager.ResetPin()

[Kukkonen, Jussi]

[-- Attachment #1: Type: text/plain, Size: 561 bytes --]

On Fri, Dec 23, 2011 at 9:28 AM, Denis Kenzior <denkenz@gmail.com> wrote:
> Hi Jussi,
>
> On 12/23/2011 12:48 PM, Kukkonen, Jussi wrote:
>> Hi all,
>>
>> I consistently get a crash when calling SimManager.ResetPin ("puk",
>> puk, new_pin). Before this I've called ChangePin()  with wrong pin
>> three times.to get "PinRequired=puk" property change.
>>
>> This is a huawei E1550 USB modem.
>>
>
> Can you please try the following patch?
>
> Regards,
> -Denis

That works nicely, I cannot reproduce the crash with your patch. thanks.

Jussi