From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM/of: allow *machine_desc.dt_compat to be const
Date: Tue, 27 Dec 2011 15:39:23 -0600 [thread overview]
Message-ID: <4EFA3B0B.8020808@gmail.com> (raw)
In-Reply-To: <1324418205-30355-1-git-send-email-u.kleine-koenig@pengutronix.de>
On 12/20/2011 03:56 PM, Uwe Kleine-K?nig wrote:
> This allows dt_compat to point to a constant list of compatible strings.
>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> does this need to be split into an of and an ARM part?
No, I don't think so. I've applied it.
Thanks,
Rob
>
> Best regards
> Uwe
>
> arch/arm/include/asm/mach/arch.h | 2 +-
> drivers/of/fdt.c | 4 ++--
> include/linux/of_fdt.h | 4 ++--
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/include/asm/mach/arch.h b/arch/arm/include/asm/mach/arch.h
> index 2b0efc3..02a718a 100644
> --- a/arch/arm/include/asm/mach/arch.h
> +++ b/arch/arm/include/asm/mach/arch.h
> @@ -19,7 +19,7 @@ struct machine_desc {
> unsigned int nr; /* architecture number */
> const char *name; /* architecture name */
> unsigned long atag_offset; /* tagged list (relative) */
> - const char **dt_compat; /* array of device tree
> + const char *const *dt_compat; /* array of device tree
> * 'compatible' strings */
>
> unsigned int nr_irqs; /* number of IRQs */
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index fd85fa2..7dc8e6d 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -107,7 +107,7 @@ int of_fdt_is_compatible(struct boot_param_header *blob,
> * of_fdt_match - Return true if node matches a list of compatible values
> */
> int of_fdt_match(struct boot_param_header *blob, unsigned long node,
> - const char **compat)
> + const char *const *compat)
> {
> unsigned int tmp, score = 0;
>
> @@ -541,7 +541,7 @@ int __init of_flat_dt_is_compatible(unsigned long node, const char *compat)
> /**
> * of_flat_dt_match - Return true if node matches a list of compatible values
> */
> -int __init of_flat_dt_match(unsigned long node, const char **compat)
> +int __init of_flat_dt_match(unsigned long node, const char *const *compat)
> {
> return of_fdt_match(initial_boot_params, node, compat);
> }
> diff --git a/include/linux/of_fdt.h b/include/linux/of_fdt.h
> index c84d900..ed136ad 100644
> --- a/include/linux/of_fdt.h
> +++ b/include/linux/of_fdt.h
> @@ -71,7 +71,7 @@ extern int of_fdt_is_compatible(struct boot_param_header *blob,
> unsigned long node,
> const char *compat);
> extern int of_fdt_match(struct boot_param_header *blob, unsigned long node,
> - const char **compat);
> + const char *const *compat);
> extern void of_fdt_unflatten_tree(unsigned long *blob,
> struct device_node **mynodes);
>
> @@ -88,7 +88,7 @@ extern int of_scan_flat_dt(int (*it)(unsigned long node, const char *uname,
> extern void *of_get_flat_dt_prop(unsigned long node, const char *name,
> unsigned long *size);
> extern int of_flat_dt_is_compatible(unsigned long node, const char *name);
> -extern int of_flat_dt_match(unsigned long node, const char **matches);
> +extern int of_flat_dt_match(unsigned long node, const char *const *matches);
> extern unsigned long of_get_flat_dt_root(void);
>
> extern int early_init_dt_scan_chosen(unsigned long node, const char *uname,
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Uwe Kleine-König"
<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] ARM/of: allow *machine_desc.dt_compat to be const
Date: Tue, 27 Dec 2011 15:39:23 -0600 [thread overview]
Message-ID: <4EFA3B0B.8020808@gmail.com> (raw)
In-Reply-To: <1324418205-30355-1-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
On 12/20/2011 03:56 PM, Uwe Kleine-König wrote:
> This allows dt_compat to point to a constant list of compatible strings.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> does this need to be split into an of and an ARM part?
No, I don't think so. I've applied it.
Thanks,
Rob
>
> Best regards
> Uwe
>
> arch/arm/include/asm/mach/arch.h | 2 +-
> drivers/of/fdt.c | 4 ++--
> include/linux/of_fdt.h | 4 ++--
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/include/asm/mach/arch.h b/arch/arm/include/asm/mach/arch.h
> index 2b0efc3..02a718a 100644
> --- a/arch/arm/include/asm/mach/arch.h
> +++ b/arch/arm/include/asm/mach/arch.h
> @@ -19,7 +19,7 @@ struct machine_desc {
> unsigned int nr; /* architecture number */
> const char *name; /* architecture name */
> unsigned long atag_offset; /* tagged list (relative) */
> - const char **dt_compat; /* array of device tree
> + const char *const *dt_compat; /* array of device tree
> * 'compatible' strings */
>
> unsigned int nr_irqs; /* number of IRQs */
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index fd85fa2..7dc8e6d 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -107,7 +107,7 @@ int of_fdt_is_compatible(struct boot_param_header *blob,
> * of_fdt_match - Return true if node matches a list of compatible values
> */
> int of_fdt_match(struct boot_param_header *blob, unsigned long node,
> - const char **compat)
> + const char *const *compat)
> {
> unsigned int tmp, score = 0;
>
> @@ -541,7 +541,7 @@ int __init of_flat_dt_is_compatible(unsigned long node, const char *compat)
> /**
> * of_flat_dt_match - Return true if node matches a list of compatible values
> */
> -int __init of_flat_dt_match(unsigned long node, const char **compat)
> +int __init of_flat_dt_match(unsigned long node, const char *const *compat)
> {
> return of_fdt_match(initial_boot_params, node, compat);
> }
> diff --git a/include/linux/of_fdt.h b/include/linux/of_fdt.h
> index c84d900..ed136ad 100644
> --- a/include/linux/of_fdt.h
> +++ b/include/linux/of_fdt.h
> @@ -71,7 +71,7 @@ extern int of_fdt_is_compatible(struct boot_param_header *blob,
> unsigned long node,
> const char *compat);
> extern int of_fdt_match(struct boot_param_header *blob, unsigned long node,
> - const char **compat);
> + const char *const *compat);
> extern void of_fdt_unflatten_tree(unsigned long *blob,
> struct device_node **mynodes);
>
> @@ -88,7 +88,7 @@ extern int of_scan_flat_dt(int (*it)(unsigned long node, const char *uname,
> extern void *of_get_flat_dt_prop(unsigned long node, const char *name,
> unsigned long *size);
> extern int of_flat_dt_is_compatible(unsigned long node, const char *name);
> -extern int of_flat_dt_match(unsigned long node, const char **matches);
> +extern int of_flat_dt_match(unsigned long node, const char *const *matches);
> extern unsigned long of_get_flat_dt_root(void);
>
> extern int early_init_dt_scan_chosen(unsigned long node, const char *uname,
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
next prev parent reply other threads:[~2011-12-27 21:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 21:56 [PATCH] ARM/of: allow *machine_desc.dt_compat to be const Uwe Kleine-König
2011-12-20 21:56 ` Uwe Kleine-König
2011-12-27 21:39 ` Rob Herring [this message]
2011-12-27 21:39 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EFA3B0B.8020808@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.