From: Huang Shijie <b32955@freescale.com>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: shijie8@gmail.com, Artem.Bityutskiy@intel.com,
linux-mtd@lists.infradead.org,
Shawn Guo <shawn.guo@freescale.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] MTD/GPMI : select more modules for GPMI by default
Date: Sat, 31 Dec 2011 15:10:44 +0800 [thread overview]
Message-ID: <4EFEB574.7060905@freescale.com> (raw)
In-Reply-To: <201112310801.39019.marek.vasut@gmail.com>
于 2011年12月31日 15:01, Marek Vasut 写道:
>> 于 2011年12月31日 13:44, Shawn Guo 写道:
>>> On Fri, Dec 30, 2011 at 12:45:37PM +0800, Huang Shijie wrote:
>>>> The gpmi-nand driver needs the mxs-dma driver. So select the
>>>> MXS_DMA by default. So does the MTD_CHAR.
>>>>
>>>> Signed-off-by: Huang Shijie<b32955@freescale.com>
>>>> ---
>>>>
>>>> drivers/mtd/nand/Kconfig | 2 ++
>>>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
>>>> index 07c4774..1b14a3a 100644
>>>> --- a/drivers/mtd/nand/Kconfig
>>>> +++ b/drivers/mtd/nand/Kconfig
>>>> @@ -420,6 +420,8 @@ config MTD_NAND_NANDSIM
>>>>
>>>> config MTD_NAND_GPMI_NAND
>>>>
>>>> bool "GPMI NAND Flash Controller driver"
>>>> depends on MTD_NAND&& (SOC_IMX23 || SOC_IMX28)
>>>>
>>>> + select MXS_DMA
>>> We should probably have it depend on MXS_DMA rather than select it.
>> IMHO, I think `select` is better. :)
>> The MXS_DMA not only service for NAND, but SD card, etc.
>> In logic, the GPMI does not depends on MXS_DMA, the GPMI may use SDMA
>> too(just in logically).
> And does it use that ? Technically, it's still dependent on MXS_DMA, right ?
NO. Just assumption.
the GPMI driver will continue to depend on MXS_DMA in the following
chips, such as MX6Q.
> Also, why select mtd_char, it's totally unrelated.
The GPMI works with UBIFS, the UBIFS is based on /dev/mtd0..,
Huang Shijie
> M
>>
>> Best Regards
>> Huang Shijie
>>
>>> Regards,
>>> Shawn
>>>
>>>> + select MTD_CHAR
>>>>
>>>> select MTD_PARTITIONS
>>>> select MTD_CMDLINE_PARTS
>>>>
>>>> help
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: b32955@freescale.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] MTD/GPMI : select more modules for GPMI by default
Date: Sat, 31 Dec 2011 15:10:44 +0800 [thread overview]
Message-ID: <4EFEB574.7060905@freescale.com> (raw)
In-Reply-To: <201112310801.39019.marek.vasut@gmail.com>
? 2011?12?31? 15:01, Marek Vasut ??:
>> ? 2011?12?31? 13:44, Shawn Guo ??:
>>> On Fri, Dec 30, 2011 at 12:45:37PM +0800, Huang Shijie wrote:
>>>> The gpmi-nand driver needs the mxs-dma driver. So select the
>>>> MXS_DMA by default. So does the MTD_CHAR.
>>>>
>>>> Signed-off-by: Huang Shijie<b32955@freescale.com>
>>>> ---
>>>>
>>>> drivers/mtd/nand/Kconfig | 2 ++
>>>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
>>>> index 07c4774..1b14a3a 100644
>>>> --- a/drivers/mtd/nand/Kconfig
>>>> +++ b/drivers/mtd/nand/Kconfig
>>>> @@ -420,6 +420,8 @@ config MTD_NAND_NANDSIM
>>>>
>>>> config MTD_NAND_GPMI_NAND
>>>>
>>>> bool "GPMI NAND Flash Controller driver"
>>>> depends on MTD_NAND&& (SOC_IMX23 || SOC_IMX28)
>>>>
>>>> + select MXS_DMA
>>> We should probably have it depend on MXS_DMA rather than select it.
>> IMHO, I think `select` is better. :)
>> The MXS_DMA not only service for NAND, but SD card, etc.
>> In logic, the GPMI does not depends on MXS_DMA, the GPMI may use SDMA
>> too(just in logically).
> And does it use that ? Technically, it's still dependent on MXS_DMA, right ?
NO. Just assumption.
the GPMI driver will continue to depend on MXS_DMA in the following
chips, such as MX6Q.
> Also, why select mtd_char, it's totally unrelated.
The GPMI works with UBIFS, the UBIFS is based on /dev/mtd0..,
Huang Shijie
> M
>>
>> Best Regards
>> Huang Shijie
>>
>>> Regards,
>>> Shawn
>>>
>>>> + select MTD_CHAR
>>>>
>>>> select MTD_PARTITIONS
>>>> select MTD_CMDLINE_PARTS
>>>>
>>>> help
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2011-12-31 7:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-30 4:45 [PATCH] MTD/GPMI : select more modules for GPMI by default Huang Shijie
2011-12-30 4:45 ` Huang Shijie
2011-12-31 5:44 ` Shawn Guo
2011-12-31 5:44 ` Shawn Guo
2011-12-31 5:48 ` Huang Shijie
2011-12-31 5:48 ` Huang Shijie
2011-12-31 7:01 ` Marek Vasut
2011-12-31 7:01 ` Marek Vasut
2011-12-31 7:10 ` Huang Shijie [this message]
2011-12-31 7:10 ` Huang Shijie
2011-12-31 7:24 ` Shawn Guo
2011-12-31 7:24 ` Shawn Guo
2011-12-31 7:27 ` Huang Shijie
2011-12-31 7:27 ` Huang Shijie
2011-12-31 15:46 ` Wolfram Sang
2011-12-31 15:46 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EFEB574.7060905@freescale.com \
--to=b32955@freescale.com \
--cc=Artem.Bityutskiy@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=shawn.guo@freescale.com \
--cc=shijie8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.