All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: Sebastian Herbszt <herbszt@gmx.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
	Peter Maydell <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH V2] Make python mandatory
Date: Sat, 31 Dec 2011 12:20:47 +0100	[thread overview]
Message-ID: <4EFEF00F.1070306@weilnetz.de> (raw)
In-Reply-To: <1325330087$3142@local>

Am 31.12.2011 12:14, schrieb Sebastian Herbszt:
> Make python mandatory.
>
> Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
> ---
> configure | 10 +++-------
> 1 files changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/configure b/configure
> index 640e815..a54439d 100755
> --- a/configure
> +++ b/configure
> @@ -1185,13 +1185,9 @@ if test "$solaris" = "yes" ; then
> fi
> fi
>
> -if test "$guest_agent" != "no" ; then
> - if has $python; then
> - :
> - else
> - echo "Python not found. Use --python=/path/to/python"
> - exit 1
> - fi
> +if ! has $python; then
> + echo "Python not found. Use --python=/path/to/python"
> + exit 1
> fi
>
> if test -z "$target_list" ; then

Reviewed-by: Stefan Weil <sw@weilnetz.de>

Maybe this patch can be applied via qemu-trivial.

Regards,

Stefan Weil



WARNING: multiple messages have this Message-ID (diff)
From: Stefan Weil <sw@weilnetz.de>
To: Sebastian Herbszt <herbszt@gmx.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
	Peter Maydell <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V2] Make python mandatory
Date: Sat, 31 Dec 2011 12:20:47 +0100	[thread overview]
Message-ID: <4EFEF00F.1070306@weilnetz.de> (raw)
In-Reply-To: <1325330087$3142@local>

Am 31.12.2011 12:14, schrieb Sebastian Herbszt:
> Make python mandatory.
>
> Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
> ---
> configure | 10 +++-------
> 1 files changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/configure b/configure
> index 640e815..a54439d 100755
> --- a/configure
> +++ b/configure
> @@ -1185,13 +1185,9 @@ if test "$solaris" = "yes" ; then
> fi
> fi
>
> -if test "$guest_agent" != "no" ; then
> - if has $python; then
> - :
> - else
> - echo "Python not found. Use --python=/path/to/python"
> - exit 1
> - fi
> +if ! has $python; then
> + echo "Python not found. Use --python=/path/to/python"
> + exit 1
> fi
>
> if test -z "$target_list" ; then

Reviewed-by: Stefan Weil <sw@weilnetz.de>

Maybe this patch can be applied via qemu-trivial.

Regards,

Stefan Weil

  reply	other threads:[~2011-12-31 11:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-30 22:36 [Qemu-devel] Compiling without python? Sebastian Herbszt
2011-12-30 23:08 ` Stefan Weil
2011-12-30 23:59   ` [Qemu-devel] Subject: [PATCH] Make python mandatory Sebastian Herbszt
2011-12-31  0:52     ` Peter Maydell
2011-12-31  1:00       ` Sebastian Herbszt
2011-12-31 11:14       ` [Qemu-devel] [PATCH V2] " Sebastian Herbszt
2011-12-31 11:20         ` Stefan Weil [this message]
2011-12-31 11:20           ` Stefan Weil
2012-01-03 10:53           ` [Qemu-trivial] " Stefan Hajnoczi
2012-01-03 10:53             ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2011-12-31 11:39         ` [Qemu-devel] " Peter Maydell
2012-01-01 11:45 ` [Qemu-devel] Compiling without python? Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EFEF00F.1070306@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=herbszt@gmx.de \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.