Re: [PATCH] staging:iio: isl29018: add of_match table for device-tree probing

[Jonathan Cameron <jic23@kernel.org>]

On 12/23/2011 02:44 AM, Olof Johansson wrote:
> As simple as can be right now; just one ID and no custom properties to parse.
Looks fine to me, but I'm not familiar with device tree naming
convensions so wouldn't mind a 'yes, that's right' from someone who
is!
> 
> Signed-off-by: Olof Johansson <olof@lixom.net>
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
>  drivers/staging/iio/light/isl29018.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c
> index 849d6a5..38ec52b 100644
> --- a/drivers/staging/iio/light/isl29018.c
> +++ b/drivers/staging/iio/light/isl29018.c
> @@ -592,11 +592,18 @@ static const struct i2c_device_id isl29018_id[] = {
>  
>  MODULE_DEVICE_TABLE(i2c, isl29018_id);
>  
> +static const struct of_device_id isl29018_of_match[] = {
> +	{ .compatible = "invn,isl29018", },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(of, isl29018_of_match);
> +
>  static struct i2c_driver isl29018_driver = {
>  	.class	= I2C_CLASS_HWMON,
>  	.driver	 = {
>  			.name = "isl29018",
>  			.owner = THIS_MODULE,
> +			.of_match_table = isl29018_of_match,
>  		    },
>  	.probe	 = isl29018_probe,
>  	.remove	 = __devexit_p(isl29018_remove),