From: Felix Fietkau <nbd@openwrt.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [RFC] ath9k_hw: make use of ar9003_calc_ptr_chksum
Date: Mon, 02 Jan 2012 15:17:41 +0100 [thread overview]
Message-ID: <4F01BC85.8050806@openwrt.org> (raw)
In-Reply-To: <4F01B9CF.2020206@qca.qualcomm.com>
On 2012-01-02 3:06 PM, Mohammed Shafi Shajakhan wrote:
> hi Felix,
>
>
> On Monday 02 January 2012 07:11 PM, Felix Fietkau wrote:
>> On 2012-01-02 2:13 PM, Mohammed Shafi Shajakhan wrote:
>>> From: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>>>
>>> make use of the already available function 'ar9003_calc_ptr_chksum'
>>> in 'ar9003_set_txdesc'
>>>
>>> Signed-off-by: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>> NACK. I intentionally did not use that function to avoid unnecessary
>> access to uncached memory (for performance reasons).
>
> please explain how it effects the performance and will it cause a
> significant impact
I don't have any exact numbers anymore, but it was visible enough in the
oprofile stats to justify a little functional duplication of code.
Eventually this duplication can go away if I can change the
ar9003_hw_set_desc_link function to incrementally fix up the checksum
instead of recalculating it, which would make the code even more efficient.
- Felix
WARNING: multiple messages have this Message-ID (diff)
From: Felix Fietkau <nbd@openwrt.org>
To: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Jouni Malinen <jouni@qca.qualcomm.com>,
linux-wireless@vger.kernel.org,
Rodriguez Luis <rodrigue@qca.qualcomm.com>,
Balasubramanian senthilkumar <senthilb@qca.qualcomm.com>,
Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>,
Rajkumar Manoharan <rmanohar@qca.qualcomm.com>,
Vivek Natarajan <nataraja@qca.qualcomm.com>,
m.sujith@gmail.com, ath9k-devel@lists.ath9k.org
Subject: Re: [RFC] ath9k_hw: make use of ar9003_calc_ptr_chksum
Date: Mon, 02 Jan 2012 15:17:41 +0100 [thread overview]
Message-ID: <4F01BC85.8050806@openwrt.org> (raw)
In-Reply-To: <4F01B9CF.2020206@qca.qualcomm.com>
On 2012-01-02 3:06 PM, Mohammed Shafi Shajakhan wrote:
> hi Felix,
>
>
> On Monday 02 January 2012 07:11 PM, Felix Fietkau wrote:
>> On 2012-01-02 2:13 PM, Mohammed Shafi Shajakhan wrote:
>>> From: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>>>
>>> make use of the already available function 'ar9003_calc_ptr_chksum'
>>> in 'ar9003_set_txdesc'
>>>
>>> Signed-off-by: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>> NACK. I intentionally did not use that function to avoid unnecessary
>> access to uncached memory (for performance reasons).
>
> please explain how it effects the performance and will it cause a
> significant impact
I don't have any exact numbers anymore, but it was visible enough in the
oprofile stats to justify a little functional duplication of code.
Eventually this duplication can go away if I can change the
ar9003_hw_set_desc_link function to incrementally fix up the checksum
instead of recalculating it, which would make the code even more efficient.
- Felix
next prev parent reply other threads:[~2012-01-02 14:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-02 13:13 [ath9k-devel] [RFC] ath9k_hw: make use of ar9003_calc_ptr_chksum Mohammed Shafi Shajakhan
2012-01-02 13:13 ` Mohammed Shafi Shajakhan
2012-01-02 13:41 ` [ath9k-devel] " Felix Fietkau
2012-01-02 13:41 ` Felix Fietkau
2012-01-02 14:06 ` [ath9k-devel] " Mohammed Shafi Shajakhan
2012-01-02 14:06 ` Mohammed Shafi Shajakhan
2012-01-02 14:17 ` Felix Fietkau [this message]
2012-01-02 14:17 ` Felix Fietkau
2012-01-02 14:19 ` [ath9k-devel] " Mohammed Shafi Shajakhan
2012-01-02 14:19 ` Mohammed Shafi Shajakhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F01BC85.8050806@openwrt.org \
--to=nbd@openwrt.org \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.