From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/8] notifier: switch to QLIST
Date: Tue, 03 Jan 2012 12:59:54 +0100 [thread overview]
Message-ID: <4F02EDBA.8090808@redhat.com> (raw)
In-Reply-To: <20120103115448.GB28826@stefanha-thinkpad.localdomain>
On 01/03/2012 12:54 PM, Stefan Hajnoczi wrote:
> On Mon, Jan 02, 2012 at 07:00:30PM +0100, Paolo Bonzini wrote:
>> void notifier_list_add(NotifierList *list, Notifier *notifier)
>> {
>> - QTAILQ_INSERT_HEAD(&list->notifiers, notifier, node);
>> + QLIST_INSERT_HEAD(&list->notifiers, notifier, node);
>> }
>>
>> -void notifier_list_remove(NotifierList *list, Notifier *notifier)
>> +void notifier_remove(Notifier *notifier)
>
> Why introduce this asymmetry with notifier_list_add() and
> notifier_remove()? Please make the function names consistent.
Because notifier_list_add adds the notifier to a specific NotifierList;
notifier_remove removes the notifier from whatever list it is in.
Normally whoever implements notifiers does not have access to the
NotifierList, so there are wrappers for both notifier_list_add and
notifier_list_remove. This patch changes things so that the wrappers
for notifier_remove are not needed anymore (though this series was
already big enough, so I left the wrappers in).
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/8] notifier: switch to QLIST
Date: Tue, 03 Jan 2012 12:59:54 +0100 [thread overview]
Message-ID: <4F02EDBA.8090808@redhat.com> (raw)
In-Reply-To: <20120103115448.GB28826@stefanha-thinkpad.localdomain>
On 01/03/2012 12:54 PM, Stefan Hajnoczi wrote:
> On Mon, Jan 02, 2012 at 07:00:30PM +0100, Paolo Bonzini wrote:
>> void notifier_list_add(NotifierList *list, Notifier *notifier)
>> {
>> - QTAILQ_INSERT_HEAD(&list->notifiers, notifier, node);
>> + QLIST_INSERT_HEAD(&list->notifiers, notifier, node);
>> }
>>
>> -void notifier_list_remove(NotifierList *list, Notifier *notifier)
>> +void notifier_remove(Notifier *notifier)
>
> Why introduce this asymmetry with notifier_list_add() and
> notifier_remove()? Please make the function names consistent.
Because notifier_list_add adds the notifier to a specific NotifierList;
notifier_remove removes the notifier from whatever list it is in.
Normally whoever implements notifiers does not have access to the
NotifierList, so there are wrappers for both notifier_list_add and
notifier_list_remove. This patch changes things so that the wrappers
for notifier_remove are not needed anymore (though this series was
already big enough, so I left the wrappers in).
Paolo
next prev parent reply other threads:[~2012-01-03 12:00 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-02 18:00 [Qemu-trivial] [PATCH 0/8] qemu-queue cleanups Paolo Bonzini
2012-01-02 18:00 ` [Qemu-devel] " Paolo Bonzini
2012-01-02 18:00 ` [Qemu-trivial] [PATCH 1/8] notifier: switch to QLIST Paolo Bonzini
2012-01-02 18:00 ` [Qemu-devel] " Paolo Bonzini
2012-01-03 11:54 ` [Qemu-trivial] " Stefan Hajnoczi
2012-01-03 11:54 ` Stefan Hajnoczi
2012-01-03 11:59 ` Paolo Bonzini [this message]
2012-01-03 11:59 ` Paolo Bonzini
2012-01-03 12:09 ` [Qemu-trivial] " Stefan Hajnoczi
2012-01-03 12:09 ` Stefan Hajnoczi
2012-01-02 18:00 ` [Qemu-trivial] [PATCH 2/8] block-migration: switch to QTAILQ Paolo Bonzini
2012-01-02 18:00 ` [Qemu-devel] " Paolo Bonzini
2012-01-02 18:00 ` [Qemu-trivial] [PATCH 3/8] qed: " Paolo Bonzini
2012-01-02 18:00 ` [Qemu-devel] " Paolo Bonzini
2012-01-02 18:00 ` [Qemu-trivial] [PATCH 4/8] ccid: " Paolo Bonzini
2012-01-02 18:00 ` [Qemu-devel] " Paolo Bonzini
2012-01-02 18:00 ` [Qemu-trivial] [PATCH 5/8] qemu-queue: really simplify QSIMPLEQ Paolo Bonzini
2012-01-02 18:00 ` [Qemu-devel] " Paolo Bonzini
2012-01-03 12:04 ` [Qemu-trivial] " Stefan Hajnoczi
2012-01-03 12:04 ` [Qemu-devel] " Stefan Hajnoczi
2012-01-13 16:04 ` [Qemu-trivial] [Qemu-devel] " Peter Maydell
2012-01-13 16:04 ` Peter Maydell
2012-01-02 18:00 ` [Qemu-trivial] [PATCH 6/8] qemu-queue: drop QCIRCLEQ Paolo Bonzini
2012-01-02 18:00 ` [Qemu-devel] " Paolo Bonzini
2012-01-02 18:00 ` [Qemu-trivial] [PATCH 7/8] coroutine: switch to QSIMPLEQ Paolo Bonzini
2012-01-02 18:00 ` [Qemu-devel] " Paolo Bonzini
2012-01-02 18:00 ` [Qemu-trivial] [PATCH 8/8] block: use QSIMPLEQ for the AIO free list Paolo Bonzini
2012-01-02 18:00 ` [Qemu-devel] " Paolo Bonzini
2012-01-03 12:07 ` [Qemu-trivial] [PATCH 0/8] qemu-queue cleanups Stefan Hajnoczi
2012-01-03 12:07 ` [Qemu-devel] " Stefan Hajnoczi
2012-01-13 15:47 ` [Qemu-devel] " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F02EDBA.8090808@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.