All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cousson, Benoit" <b-cousson@ti.com>
To: grant.likely@secretlab.ca
Cc: Rob Herring <robherring2@gmail.com>,
	devicetree-discuss@lists.ozlabs.org, tony@atomide.com,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] of/base: Take NULL string into account for property with multiple strings
Date: Tue, 3 Jan 2012 15:15:05 +0100	[thread overview]
Message-ID: <4F030D69.5010709@ti.com> (raw)
In-Reply-To: <4EEF4401.1060303@gmail.com>

Hi Grant,

On 12/19/2011 3:02 PM, Rob Herring wrote:
> On 12/05/2011 08:23 AM, Benoit Cousson wrote:
>> The current implementation just ignore any NULL string inserted in a
>> multiple strings property.
>> In some cases we can have a property with a fix number of strings but
>> not necessarily used, like for example in a list of valid pinmux modes.
>>
>>   prop = "uart_rx", "uart_tx", "", "", "safe_mode";
>>
>> Do no skip NULL string and take them into account in
>> of_property_read_string_index and of_property_count_strings.
>>
>> Reported-by: Tony Lindgren<tony@atomide.com>
>> Signed-off-by: Benoit Cousson<b-cousson@ti.com>
>> Cc: Grant Likely<grant.likely@secretlab.ca>
>> Cc: Rob Herring<rob.herring@calxeda.com>
>
> Applied. The others need Grant's agreement.

New year gentle ping.

Thanks,
Benoit

WARNING: multiple messages have this Message-ID (diff)
From: b-cousson@ti.com (Cousson, Benoit)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] of/base: Take NULL string into account for property with multiple strings
Date: Tue, 3 Jan 2012 15:15:05 +0100	[thread overview]
Message-ID: <4F030D69.5010709@ti.com> (raw)
In-Reply-To: <4EEF4401.1060303@gmail.com>

Hi Grant,

On 12/19/2011 3:02 PM, Rob Herring wrote:
> On 12/05/2011 08:23 AM, Benoit Cousson wrote:
>> The current implementation just ignore any NULL string inserted in a
>> multiple strings property.
>> In some cases we can have a property with a fix number of strings but
>> not necessarily used, like for example in a list of valid pinmux modes.
>>
>>   prop = "uart_rx", "uart_tx", "", "", "safe_mode";
>>
>> Do no skip NULL string and take them into account in
>> of_property_read_string_index and of_property_count_strings.
>>
>> Reported-by: Tony Lindgren<tony@atomide.com>
>> Signed-off-by: Benoit Cousson<b-cousson@ti.com>
>> Cc: Grant Likely<grant.likely@secretlab.ca>
>> Cc: Rob Herring<rob.herring@calxeda.com>
>
> Applied. The others need Grant's agreement.

New year gentle ping.

Thanks,
Benoit

  reply	other threads:[~2012-01-03 14:15 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-05 14:23 [PATCH 0/3] of: Add support for named irq and reg Benoit Cousson
2011-12-05 14:23 ` Benoit Cousson
2011-12-05 14:23 ` [PATCH 1/3] of/base: Take NULL string into account for property with multiple strings Benoit Cousson
2011-12-05 14:23   ` Benoit Cousson
2011-12-14 18:18   ` Tony Lindgren
2011-12-14 18:18     ` Tony Lindgren
2011-12-19 14:02   ` Rob Herring
2011-12-19 14:02     ` Rob Herring
2012-01-03 14:15     ` Cousson, Benoit [this message]
2012-01-03 14:15       ` Cousson, Benoit
2012-01-04  7:34       ` Grant Likely
2012-01-04  7:34         ` Grant Likely
2011-12-05 14:23 ` [PATCH 2/3] of/address: Add reg-names property to name an iomem resource Benoit Cousson
2011-12-05 14:23   ` Benoit Cousson
2011-12-05 14:23 ` [PATCH 3/3] of/irq: Add interrupts-names property to name an irq resource Benoit Cousson
2011-12-05 14:23   ` Benoit Cousson
2012-01-04  7:17   ` Grant Likely
2012-01-04  7:17     ` Grant Likely
     [not found]     ` <20120104071749.GA15503-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2012-01-04 14:15       ` Cousson, Benoit
2012-01-04 14:15         ` Cousson, Benoit
2011-12-19 13:50 ` [PATCH 0/3] of: Add support for named irq and reg Cousson, Benoit
2011-12-19 13:50   ` Cousson, Benoit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F030D69.5010709@ti.com \
    --to=b-cousson@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robherring2@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.