Re: [Qemu-devel] [PULL][v2] Remove cpu_get_physical_page_desc

[Anthony Liguori <anthony@codemonkey.ws>]

On 12/27/2011 09:38 AM, Avi Kivity wrote:
> Changes since first posting: fold a fixup patch into its parent patch,
> style fixes.
>
> I didn't get much review or testing for vhost or Xen, due to various
> issues around births separated by a large amount of time if not
> distance, but I don't want to get this series to get stale.  Given that
> both are rather niche I think we can fix any issues in tree.
>
> Michael did suggest making changes to vhost, but I prefer that he makes
> them as he knows how to test.
>
> Please pull from
>
>    git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/page_desc
>
>
> v2: fix build (and runtime) breakage in virtio_balloon.

There's another breakage:

   CC    i386-softmmu/xen-all.o
cc1: warnings being treated as errors
/home/anthony/git/qemu/xen-all.c: In function ‘xen_set_memory’:
/home/anthony/git/qemu/xen-all.c:376:32: error: passing argument 4 of 
‘xen_add_to_physmap’ makes integer from pointer without a cast
/home/anthony/git/qemu/xen-all.c:333:12: note: expected ‘target_phys_addr_t’ but 
argument is of type ‘struct MemoryRegion *’
/home/anthony/git/qemu/xen-all.c:376:32: error: too many arguments to function 
‘xen_add_to_physmap’
/home/anthony/git/qemu/xen-all.c:333:12: note: declared here
make[1]: *** [xen-all.o] Error 1
make: *** [subdir-i386-softmmu] Error 2

Regards,

Anthony Liguori

>
> Avi Kivity (22):
>        sysbus: add sysbus_address_space()
>        memory: add memory_region_is_ram()
>        memory: add memory_region_is_rom()
>        memory: add memory_region_is_logging()
>        memory: introduce memory_region_find()
>        framebuffer: drop use of cpu_get_physical_page_desc()
>        loader: remove calls to cpu_get_physical_page_desc()
>        framebuffer: drop use of cpu_physical_sync_dirty_bitmap()
>        memory: replace cpu_physical_sync_dirty_bitmap() with a memory API
>        memory: add API for observing updates to the physical memory map
>        kvm: switch kvm slots to use host virtual address instead of
> ram_addr_t
>        kvm: convert to MemoryListener API
>        vhost: convert to MemoryListener API
>        xen, vga: add API for registering the framebuffer
>        memory: temporarily add memory_region_get_ram_addr()
>        xen: convert to MemoryListener API
>        memory: remove CPUPhysMemoryClient
>        kvm: avoid cpu_get_physical_page_desc()
>        vhost: avoid cpu_get_physical_page_desc()
>        virtio-balloon: avoid cpu_get_physical_page_desc()
>        sparc: avoid cpu_get_physical_page_desc()
>        Remove cpu_get_physical_page_desc()
>
>   arch_init.c               |    6 +-
>   cpu-all.h                 |    9 --
>   cpu-common.h              |   24 ------
>   exec.c                    |  175 +---------------------------------------
>   hw/framebuffer.c          |   32 +++----
>   hw/framebuffer.h          |    3 +
>   hw/loader.c               |    9 +-
>   hw/milkymist-vgafb.c      |    2 +-
>   hw/omap_lcdc.c            |    4 +-
>   hw/pl110.c                |    2 +-
>   hw/pxa2xx_lcd.c           |   10 ++-
>   hw/sysbus.c               |    5 +
>   hw/sysbus.h               |    1 +
>   hw/vga.c                  |    2 +
>   hw/vhost.c                |  167 ++++++++++++++++++++++++++++++---------
>   hw/vhost.h                |    5 +-
>   hw/virtio-balloon.c       |   14 +++-
>   hw/xen.h                  |    3 +
>   kvm-all.c                 |  151 +++++++++++++++++++++--------------
>   kvm.h                     |    4 +-
>   memory.c                  |  193
> ++++++++++++++++++++++++++++++++++++++++++---
>   memory.h                  |  134 +++++++++++++++++++++++++++++++
>   target-i386/kvm.c         |    7 +-
>   target-sparc/mmu_helper.c |    5 +-
>   trace-events              |    2 +-
>   xen-all.c                 |  143 ++++++++++++++++++++-------------
>   xen-stub.c                |    4 +
>   27 files changed, 702 insertions(+), 414 deletions(-)
>