Re: [Qemu-devel] [PULL][v2] Remove cpu_get_physical_page_desc

[Avi Kivity <avi@redhat.com>]

On 01/03/2012 07:06 PM, Anthony Liguori wrote:
> On 12/27/2011 09:38 AM, Avi Kivity wrote:
>> Changes since first posting: fold a fixup patch into its parent patch,
>> style fixes.
>>
>> I didn't get much review or testing for vhost or Xen, due to various
>> issues around births separated by a large amount of time if not
>> distance, but I don't want to get this series to get stale.  Given that
>> both are rather niche I think we can fix any issues in tree.
>>
>> Michael did suggest making changes to vhost, but I prefer that he makes
>> them as he knows how to test.
>>
>> Please pull from
>>
>>    git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/page_desc
>>
>>
>> v2: fix build (and runtime) breakage in virtio_balloon.
>
> There's another breakage:
>
>   CC    i386-softmmu/xen-all.o
> cc1: warnings being treated as errors
> /home/anthony/git/qemu/xen-all.c: In function ‘xen_set_memory’:
> /home/anthony/git/qemu/xen-all.c:376:32: error: passing argument 4 of
> ‘xen_add_to_physmap’ makes integer from pointer without a cast
> /home/anthony/git/qemu/xen-all.c:333:12: note: expected
> ‘target_phys_addr_t’ but argument is of type ‘struct MemoryRegion *’
> /home/anthony/git/qemu/xen-all.c:376:32: error: too many arguments to
> function ‘xen_add_to_physmap’
> /home/anthony/git/qemu/xen-all.c:333:12: note: declared here
> make[1]: *** [xen-all.o] Error 1
> make: *** [subdir-i386-softmmu] Error 2
>

Sorry about that - will fix asap.

(strange, I was 100% sure I tested Xen).

-- 
error compiling committee.c: too many arguments to function