All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@domain.hid>
To: Fabrice Gasnier <fabrice.gasnier@domain.hid>
Cc: xenomai@xenomai.org
Subject: Re: [Xenomai-help] Xenomai rtcan build issue on MPC5121 (kernel >= 2.6.35)
Date: Wed, 04 Jan 2012 13:30:35 +0100	[thread overview]
Message-ID: <4F04466B.2000609@domain.hid> (raw)
In-Reply-To: <4F0424A0.3010206@domain.hid>

Hi Fabrice,

On 01/04/2012 11:06 AM, Fabrice Gasnier wrote:
> Thanks Gilles.
> 
> I posted some time ago another question that is somehow related to rtcan
> and mpc5121:
> insmod xeno_rtcan_mscan gets stuck on MPC5121
> https://mail.gna.org/public/xenomai-core/2011-09/msg00032.html
> 
> I still have this issue and prepared a re-worked patch that you can find
> attached to this email.
> Can this also be applied?

Looks good. This patch is obviously derived from the MSCAN driver of the
Linux kernel where we know that it works:

  http://lxr.linux.no/#linux+v3.1.7/drivers/net/can/mscan/mscan.c#L62

Just a minor issue:

s/rinit=0/rinit = 0/

Could please send a separate patch inline. I will do some testing on my
MPC5200 and MPC5121 boards later this week.

Thanks,

Wolfgang.


  reply	other threads:[~2012-01-04 12:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-21 11:22 [Xenomai-help] Xenomai rtcan build issue on MPC5121 (kernel >= 2.6.35) Fabrice Gasnier
2011-12-26 17:54 ` Gilles Chanteperdrix
2012-01-03  8:47   ` Fabrice Gasnier
2012-01-03 21:03     ` Gilles Chanteperdrix
2012-01-04 10:06       ` Fabrice Gasnier
2012-01-04 12:30         ` Wolfgang Grandegger [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-01-04 13:48 Fabrice Gasnier
2012-01-04 15:53 ` Wolfgang Grandegger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F04466B.2000609@domain.hid \
    --to=wg@domain.hid \
    --cc=fabrice.gasnier@domain.hid \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.