From: Wolfgang Grandegger <wg@domain.hid>
To: Fabrice Gasnier <fabrice.gasnier@domain.hid>
Cc: xenomai@xenomai.org
Subject: Re: [Xenomai-help] Xenomai rtcan build issue on MPC5121 (kernel >= 2.6.35)
Date: Wed, 04 Jan 2012 16:53:09 +0100 [thread overview]
Message-ID: <4F0475E5.5030301@domain.hid> (raw)
In-Reply-To: <4F04589A.5090404@domain.hid>
On 01/04/2012 02:48 PM, Fabrice Gasnier wrote:
> ---
> ksrc/drivers/can/mscan/rtcan_mscan.c | 38
> ++++++++++++++++++++++++++++++++-
> 1 files changed, 36 insertions(+), 2 deletions(-)
>
Unfortunately, this is not a proper patch. It should have:
- a descriptive subject line, e.g.:
[PATCH] fix mscan init on mpc5121
- a short description of the patch. Why? What does it fix?
- your signed-off-by line.
Furthermore, the patch should be send *inline* (and not as attachment).
The best is to setup and use "git send-email" for that purpose.
Otherwise you need to tweak you mail clients somehow to avoid
white-space mangling.
Thanks,
Wolfgang.
next prev parent reply other threads:[~2012-01-04 15:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 13:48 [Xenomai-help] Xenomai rtcan build issue on MPC5121 (kernel >= 2.6.35) Fabrice Gasnier
2012-01-04 15:53 ` Wolfgang Grandegger [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-12-21 11:22 Fabrice Gasnier
2011-12-26 17:54 ` Gilles Chanteperdrix
2012-01-03 8:47 ` Fabrice Gasnier
2012-01-03 21:03 ` Gilles Chanteperdrix
2012-01-04 10:06 ` Fabrice Gasnier
2012-01-04 12:30 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0475E5.5030301@domain.hid \
--to=wg@domain.hid \
--cc=fabrice.gasnier@domain.hid \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.