From: Larry Finger <Larry.Finger@lwfinger.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: davem@davemloft.net, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: pull request: wireless 2012-01-04
Date: Wed, 04 Jan 2012 11:40:54 -0600 [thread overview]
Message-ID: <4F048F26.5000804@lwfinger.net> (raw)
In-Reply-To: <20120104163109.GF2540@tuxdriver.com>
On 01/04/2012 10:31 AM, John W. Linville wrote:
> On Wed, Jan 04, 2012 at 10:58:16AM -0500, John W. Linville wrote:
>
>> I was hesitant to include the rtlwifi fix, but settled on inclusion
>> because it was a product of a recent ginormous thread about the
>> intersection of firmware loading and suspend/resume. Plus it fixes
>> a bug report in the Red Hat Bugzilla. :-) If you don't think it is
>> worthy, let me know and I'll drop it from this release.
>
> It looks like this could generate a build warning...
>
> http://marc.info/?l=linux-wireless&m=132569396407866&w=2
>
> I'm getting cold feet on this one. I withdraw this pull request --
> new one to follow soon!
John,
I will resubmit this patch with a fix.
I now realize that my fix has a different problem in that the firmware might not
be preserved under certain scenarios if there were two instances of the device
sharing the driver. These are corner cases, but I would like to fix that as well.
Is there any way for a driver to know that it is being initialized for a second
device?
Thanks,
Larry
WARNING: multiple messages have this Message-ID (diff)
From: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
To: "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Cc: davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: pull request: wireless 2012-01-04
Date: Wed, 04 Jan 2012 11:40:54 -0600 [thread overview]
Message-ID: <4F048F26.5000804@lwfinger.net> (raw)
In-Reply-To: <20120104163109.GF2540-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
On 01/04/2012 10:31 AM, John W. Linville wrote:
> On Wed, Jan 04, 2012 at 10:58:16AM -0500, John W. Linville wrote:
>
>> I was hesitant to include the rtlwifi fix, but settled on inclusion
>> because it was a product of a recent ginormous thread about the
>> intersection of firmware loading and suspend/resume. Plus it fixes
>> a bug report in the Red Hat Bugzilla. :-) If you don't think it is
>> worthy, let me know and I'll drop it from this release.
>
> It looks like this could generate a build warning...
>
> http://marc.info/?l=linux-wireless&m=132569396407866&w=2
>
> I'm getting cold feet on this one. I withdraw this pull request --
> new one to follow soon!
John,
I will resubmit this patch with a fix.
I now realize that my fix has a different problem in that the firmware might not
be preserved under certain scenarios if there were two instances of the device
sharing the driver. These are corner cases, but I would like to fix that as well.
Is there any way for a driver to know that it is being initialized for a second
device?
Thanks,
Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-01-04 17:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 15:58 pull request: wireless 2012-01-04 John W. Linville
2012-01-04 16:31 ` John W. Linville
2012-01-04 17:40 ` Larry Finger [this message]
2012-01-04 17:40 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F048F26.5000804@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.