* [PATCH] ext4: make local symbol ext4_initxattrs static
@ 2012-01-04 13:51 Djalal Harouni
2012-01-04 17:46 ` [PATCH] ext4: make more symbols static Eric Sandeen
2012-01-05 3:34 ` [PATCH] ext4: make local symbol ext4_initxattrs static Ted Ts'o
0 siblings, 2 replies; 4+ messages in thread
From: Djalal Harouni @ 2012-01-04 13:51 UTC (permalink / raw)
To: Theodore Ts'o, Andreas Dilger; +Cc: linux-ext4
The ext4_initxattrs symbol is used only in this file, so it should be
declared static.
Signed-off-by: Djalal Harouni <tixxdz@opendz.org>
---
fs/ext4/xattr_security.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/xattr_security.c b/fs/ext4/xattr_security.c
index 34e4350..e247f8b 100644
--- a/fs/ext4/xattr_security.c
+++ b/fs/ext4/xattr_security.c
@@ -48,8 +48,9 @@ ext4_xattr_security_set(struct dentry *dentry, const char *name,
name, value, size, flags);
}
-int ext4_initxattrs(struct inode *inode, const struct xattr *xattr_array,
- void *fs_info)
+static int
+ext4_initxattrs(struct inode *inode, const struct xattr *xattr_array,
+ void *fs_info)
{
const struct xattr *xattr;
handle_t *handle = fs_info;
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ext4: make more symbols static
2012-01-04 13:51 [PATCH] ext4: make local symbol ext4_initxattrs static Djalal Harouni
@ 2012-01-04 17:46 ` Eric Sandeen
2012-01-05 3:34 ` Ted Ts'o
2012-01-05 3:34 ` [PATCH] ext4: make local symbol ext4_initxattrs static Ted Ts'o
1 sibling, 1 reply; 4+ messages in thread
From: Eric Sandeen @ 2012-01-04 17:46 UTC (permalink / raw)
To: Djalal Harouni; +Cc: Theodore Ts'o, Andreas Dilger, linux-ext4
A couple more functions can reasonably be made static if desired.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c
index 12ccacd..f9e2cd8 100644
--- a/fs/ext4/balloc.c
+++ b/fs/ext4/balloc.c
@@ -23,6 +23,8 @@
#include <trace/events/ext4.h>
+static unsigned ext4_num_base_meta_clusters(struct super_block *sb,
+ ext4_group_t block_group);
/*
* balloc.c contains the blocks allocation and deallocation routines
*/
@@ -668,7 +670,7 @@ unsigned long ext4_bg_num_gdb(struct super_block *sb, ext4_group_t group)
* This function returns the number of file system metadata clusters at
* the beginning of a block group, including the reserved gdt blocks.
*/
-unsigned ext4_num_base_meta_clusters(struct super_block *sb,
+static unsigned ext4_num_base_meta_clusters(struct super_block *sb,
ext4_group_t block_group)
{
struct ext4_sb_info *sbi = EXT4_SB(sb);
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index ae2407f..0298efb 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -1790,8 +1790,6 @@ extern void ext4_init_block_bitmap(struct super_block *sb,
extern unsigned ext4_free_clusters_after_init(struct super_block *sb,
ext4_group_t block_group,
struct ext4_group_desc *gdp);
-extern unsigned ext4_num_base_meta_clusters(struct super_block *sb,
- ext4_group_t block_group);
extern unsigned ext4_num_overhead_clusters(struct super_block *sb,
ext4_group_t block_group,
struct ext4_group_desc *gdp);
@@ -1883,9 +1881,6 @@ extern int ext4_chunk_trans_blocks(struct inode *, int nrblocks);
extern int ext4_discard_partial_page_buffers(handle_t *handle,
struct address_space *mapping, loff_t from,
loff_t length, int flags);
-extern int ext4_discard_partial_page_buffers_no_lock(handle_t *handle,
- struct inode *inode, struct page *page, loff_t from,
- loff_t length, int flags);
extern int ext4_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf);
extern qsize_t *ext4_get_reserved_space(struct inode *inode);
extern void ext4_da_update_reserve_space(struct inode *inode,
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index fa84575..01f785a 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -72,6 +72,9 @@ static int ext4_set_bh_endio(struct buffer_head *bh, struct inode *inode);
static void ext4_end_io_buffer_write(struct buffer_head *bh, int uptodate);
static int __ext4_journalled_writepage(struct page *page, unsigned int len);
static int ext4_bh_delay_or_unwritten(handle_t *handle, struct buffer_head *bh);
+static int ext4_discard_partial_page_buffers_no_lock(handle_t *handle,
+ struct inode *inode, struct page *page, loff_t from,
+ loff_t length, int flags);
/*
* Test whether an inode is a fast symlink.
@@ -3161,7 +3164,7 @@ int ext4_discard_partial_page_buffers(handle_t *handle,
*
* Returns zero on sucess or negative on failure.
*/
-int ext4_discard_partial_page_buffers_no_lock(handle_t *handle,
+static int ext4_discard_partial_page_buffers_no_lock(handle_t *handle,
struct inode *inode, struct page *page, loff_t from,
loff_t length, int flags)
{
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ext4: make local symbol ext4_initxattrs static
2012-01-04 13:51 [PATCH] ext4: make local symbol ext4_initxattrs static Djalal Harouni
2012-01-04 17:46 ` [PATCH] ext4: make more symbols static Eric Sandeen
@ 2012-01-05 3:34 ` Ted Ts'o
1 sibling, 0 replies; 4+ messages in thread
From: Ted Ts'o @ 2012-01-05 3:34 UTC (permalink / raw)
To: Djalal Harouni; +Cc: Andreas Dilger, linux-ext4
On Wed, Jan 04, 2012 at 02:51:20PM +0100, Djalal Harouni wrote:
> The ext4_initxattrs symbol is used only in this file, so it should be
> declared static.
>
> Signed-off-by: Djalal Harouni <tixxdz@opendz.org>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ext4: make more symbols static
2012-01-04 17:46 ` [PATCH] ext4: make more symbols static Eric Sandeen
@ 2012-01-05 3:34 ` Ted Ts'o
0 siblings, 0 replies; 4+ messages in thread
From: Ted Ts'o @ 2012-01-05 3:34 UTC (permalink / raw)
To: Eric Sandeen; +Cc: Djalal Harouni, Andreas Dilger, linux-ext4
On Wed, Jan 04, 2012 at 11:46:08AM -0600, Eric Sandeen wrote:
> A couple more functions can reasonably be made static if desired.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-05 3:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-04 13:51 [PATCH] ext4: make local symbol ext4_initxattrs static Djalal Harouni
2012-01-04 17:46 ` [PATCH] ext4: make more symbols static Eric Sandeen
2012-01-05 3:34 ` Ted Ts'o
2012-01-05 3:34 ` [PATCH] ext4: make local symbol ext4_initxattrs static Ted Ts'o
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.