From: Avi Kivity <avi@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to Phys
Date: Wed, 04 Jan 2012 21:54:37 +0200 [thread overview]
Message-ID: <4F04AE7D.50109@redhat.com> (raw)
In-Reply-To: <CAFEAcA-yJETEgxVP1OGZU6RJTQmXuSBmrBDPbSjC4D-FsQh2cg@mail.gmail.com>
On 01/04/2012 09:50 PM, Peter Maydell wrote:
> On 4 January 2012 19:32, Avi Kivity <avi@redhat.com> wrote:
> > The name 'Phys' conveys exactly the same information as 'target_phys_addr_t':
> >
> > - it has to be a physical address (no such thing as physical data)
> > - it has to be a target address (qemu doesn't do host physical addresses)
> > - the fact that it's a type is implied by the naming convention
> >
> > As it's 4 characters vs. 18, and C standard compliant to boot, Phys is a
> > clear winner. Rename all instances of target_phys_addr_t to the new name.
> > All hail Phys!
> >
> > 323 files changed, 1959 insertions(+), 1959 deletions(-)
>
> Seems like gratuitous churn to me...
>
It will generate noise, but improve readability by a little bit.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2012-01-04 19:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 19:32 [Qemu-devel] [PATCH] Rename target_phys_addr_t to Phys Avi Kivity
2012-01-04 19:50 ` Peter Maydell
2012-01-04 19:54 ` Avi Kivity [this message]
2012-01-04 22:09 ` Anthony Liguori
2012-01-04 23:33 ` Peter Maydell
2012-01-05 0:16 ` Anthony Liguori
2012-01-05 0:24 ` Peter Maydell
2012-01-05 8:17 ` Stefan Weil
2012-01-07 17:44 ` Blue Swirl
2012-01-08 10:24 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F04AE7D.50109@redhat.com \
--to=avi@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.