From: Anthony Liguori <anthony@codemonkey.ws>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to Phys
Date: Wed, 04 Jan 2012 18:16:11 -0600 [thread overview]
Message-ID: <4F04EBCB.6030501@codemonkey.ws> (raw)
In-Reply-To: <CAFEAcA9=PayTiChPRRM20reE=rsgAcWXJPttfDNTkHd3F-8OXw@mail.gmail.com>
On 01/04/2012 05:33 PM, Peter Maydell wrote:
> On 4 January 2012 22:09, Anthony Liguori<anthony@codemonkey.ws> wrote:
>> target_phys_addr_t should exist IMHO in the device model code.
>
> (I assume "should not" ?)
Yes, sorry.
>
>> I think it
>> would be more useful to introduce a hw_addr, fix it at u64, make the device
>> model and memory API use that, and then make it so we didn't do the
>> silliness around libhw32/libhw64.
>
> A lot of the usage of target_phys_addr_t in hw/ is actually not
> handling addresses at all, but merely offsets into device IO regions
> (ie as parameters to device read/write functions)...
Exactly, which is why using target_phys_addr_t (and subsequently building the
device twice) doesn't make a lot of sense.
Regards,
Anthony Liguori
>
> -- PMM
>
next prev parent reply other threads:[~2012-01-05 0:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 19:32 [Qemu-devel] [PATCH] Rename target_phys_addr_t to Phys Avi Kivity
2012-01-04 19:50 ` Peter Maydell
2012-01-04 19:54 ` Avi Kivity
2012-01-04 22:09 ` Anthony Liguori
2012-01-04 23:33 ` Peter Maydell
2012-01-05 0:16 ` Anthony Liguori [this message]
2012-01-05 0:24 ` Peter Maydell
2012-01-05 8:17 ` Stefan Weil
2012-01-07 17:44 ` Blue Swirl
2012-01-08 10:24 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F04EBCB.6030501@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.